x86/PCI: do not tie MSI MS-7253 use_crs quirk to BIOS version
authorJonathan Nieder <jrnieder@gmail.com>
Tue, 28 Feb 2012 21:31:35 +0000 (15:31 -0600)
committerLuis Henriques <luis.henriques@canonical.com>
Mon, 30 Apr 2012 18:15:03 +0000 (19:15 +0100)
BugLink: http://bugs.launchpad.net/bugs/981162

commit a97f4f5e524bcd09a85ef0b8821a14d35e69335f upstream.

Carlos was getting

WARNING: at drivers/pci/pci.c:118 pci_ioremap_bar+0x24/0x52()

when probing his sound card, and sound did not work.  After adding
pci=use_crs to the kernel command line, no more trouble.

Ok, we can add a quirk.  dmidecode output reveals that this is an MSI
MS-7253, for which we already have a quirk, but the short-sighted
author tied the quirk to a single BIOS version, making it not kick in
on Carlos's machine with BIOS V1.2.  If a later BIOS update makes it
no longer necessary to look at the _CRS info it will still be
harmless, so let's stop trying to guess which versions have and don't
have accurate _CRS tables.

Addresses https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5533
Also see <https://bugzilla.kernel.org/show_bug.cgi?id=42619>.

Reported-by: Carlos Luna <caralu74@gmail.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>

arch/x86/pci/acpi.c

index dc00ad5..0ed97d8 100644 (file)
@@ -62,7 +62,6 @@ static const struct dmi_system_id pci_use_crs_table[] __initconst = {
                        DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
                        DMI_MATCH(DMI_BOARD_NAME, "MS-7253"),
                        DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies, LTD"),
-                       DMI_MATCH(DMI_BIOS_VERSION, "V1.6"),
                },
        },
        {}