USB: xhci: Fix finding extended capabilities registers
authorEdward Shao <laface.tw@gmail.com>
Wed, 10 Feb 2010 19:37:30 +0000 (03:37 +0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 2 Mar 2010 22:55:02 +0000 (14:55 -0800)
According "5.3.6 Capability Parameters (HCCPARAMS)" of xHCI rev0.96 spec,
value of xECP register indicates a relative offset, in 32-bit words,
from Base to the beginning of the first extended capability.
The wrong calculation will cause BIOS handoff fail (not handoff from BIOS)
in some platform with BIOS USB legacy sup support.

Signed-off-by: Edward Shao <laface.tw@gmail.com>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/usb/host/xhci-ext-caps.h

index ecc131c..78c4eda 100644 (file)
@@ -101,12 +101,15 @@ static inline int xhci_find_next_cap_offset(void __iomem *base, int ext_offset)
 
        next = readl(base + ext_offset);
 
-       if (ext_offset == XHCI_HCC_PARAMS_OFFSET)
+       if (ext_offset == XHCI_HCC_PARAMS_OFFSET) {
                /* Find the first extended capability */
                next = XHCI_HCC_EXT_CAPS(next);
-       else
+               ext_offset = 0;
+       } else {
                /* Find the next extended capability */
                next = XHCI_EXT_CAPS_NEXT(next);
+       }
+
        if (!next)
                return 0;
        /*