if(nonspecial<2) {
g_free(serve);
serve=NULL;
+ } else {
+ do_oldstyle = TRUE;
}
if(do_output) {
if(!serve) {
g_key_file_free(cfile);
return NULL;
}
+ if(s.port && !do_oldstyle) {
+ g_warning("A port was specified, but oldstyle exports were not requested. This may not do what you expect.");
+ g_warning("Please read 'man 5 nbd-server' and search for oldstyle for more info");
+ }
} else {
s.virtstyle=VIRT_IPLIT;
}
memset(zeros, '\0', sizeof(zeros));
if(!client || !client->modern) {
+ /* common */
if (write(net, INIT_PASSWD, 8) < 0) {
err_nonfatal("Negotiation failed: %m");
if(client)
exit(EXIT_FAILURE);
}
- magic = htonll(opts_magic);
+ if(!client || client->modern) {
+ /* modern */
+ magic = htonll(opts_magic);
+ } else {
+ /* oldstyle */
+ magic = htonll(cliserv_magic);
+ }
if (write(net, &magic, sizeof(magic)) < 0) {
err_nonfatal("Negotiation failed: %m");
if(client)
}
}
if(!client) {
- uint64_t reserved;
+ /* modern */
+ uint32_t reserved;
uint32_t opt;
- uint64_t namelen;
+ uint32_t namelen;
char* name;
int i;
read(net, &reserved, sizeof(reserved));
read(net, &magic, sizeof(magic));
magic = ntohll(magic);
- if(magic != cliserv_magic) {
+ if(magic != opts_magic) {
close(net);
return NULL;
}
return NULL;
}
read(net, &namelen, sizeof(namelen));
- namelen = ntohll(namelen);
+ namelen = ntohl(namelen);
name = malloc(namelen+1);
- name[namelen+1]=0;
+ name[namelen]=0;
read(net, name, namelen);
for(i=0; i<servers->len; i++) {
SERVER* serve = &(g_array_index(servers, SERVER, i));
return client;
}
}
+ return NULL;
}
+ /* common */
size_host = htonll((u64)(client->exportsize));
if (write(net, &size_host, 8) < 0)
err("Negotiation failed: %m");
if (client->server->flags & F_READONLY)
flags |= NBD_FLAG_READ_ONLY;
if (!client->modern) {
+ /* oldstyle */
flags = htonl(flags);
if (write(client->net, &flags, 4) < 0)
err("Negotiation failed: %m");
} else {
+ /* modern */
smallflags = (uint16_t)(flags & ~((uint16_t)0));
smallflags = htons(smallflags);
if (write(client->net, &smallflags, sizeof(smallflags)) < 0) {
err("Negotiation failed: %m");
}
}
+ /* common */
if (write(client->net, zeros, 124) < 0)
err("Negotiation failed: %m");
return NULL;
if(!client) {
err_nonfatal("negotiation failed");
close(net);
+ net=0;
}
}
for(i=0;i<servers->len && !net;i++) {