usb: gadget: pch_udc: Reduce redundant interrupt
authorTomoya MORINAGA <tomoya.rohm@gmail.com>
Thu, 12 Jan 2012 02:27:09 +0000 (11:27 +0900)
committerLuis Henriques <luis.henriques@canonical.com>
Mon, 30 Apr 2012 18:15:11 +0000 (19:15 +0100)
BugLink: http://bugs.launchpad.net/bugs/987337

commit 833310402c54ad9b676b465fc53ad276b13d36be upstream.

ISSUE:
USB Suspend interrupts occur frequently.

CAUSE:
When it is called pch_udc_reconnect() in USB Suspend, it repeats reset and
Suspend.

SOLUTION:
pch_udc_reconnect() does not enable all interrupts.  When an enumeration event
occurred the driver enables all interrupts.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>

drivers/usb/gadget/pch_udc.c

index 4d1e91e..e7fb1a3 100644 (file)
@@ -568,9 +568,7 @@ static void pch_udc_reconnect(struct pch_udc_dev *dev)
        /* enable device interrupts */
        /* pch_udc_enable_interrupts() */
        pch_udc_bit_clr(dev, UDC_DEVIRQMSK_ADDR,
-                       UDC_DEVINT_UR | UDC_DEVINT_US |
-                       UDC_DEVINT_ENUM |
-                       UDC_DEVINT_SI | UDC_DEVINT_SC);
+                       UDC_DEVINT_UR | UDC_DEVINT_ENUM);
 
        /* Clear the disconnect */
        pch_udc_bit_set(dev, UDC_DEVCTL_ADDR, UDC_DEVCTL_RES);
@@ -2419,6 +2417,11 @@ static void pch_udc_svc_enum_interrupt(struct pch_udc_dev *dev)
        pch_udc_set_dma(dev, DMA_DIR_TX);
        pch_udc_set_dma(dev, DMA_DIR_RX);
        pch_udc_ep_set_rrdy(&(dev->ep[UDC_EP0OUT_IDX]));
+
+       /* enable device interrupts */
+       pch_udc_enable_interrupts(dev, UDC_DEVINT_UR | UDC_DEVINT_US |
+                                       UDC_DEVINT_ES | UDC_DEVINT_ENUM |
+                                       UDC_DEVINT_SI | UDC_DEVINT_SC);
 }
 
 /**