usb: gadget: pch_udc: Fix wrong return value
authorTomoya MORINAGA <tomoya.rohm@gmail.com>
Thu, 12 Jan 2012 02:27:06 +0000 (11:27 +0900)
committerLuis Henriques <luis.henriques@canonical.com>
Mon, 30 Apr 2012 18:15:11 +0000 (19:15 +0100)
commit9b42e2406ea3e7512fb8ed9b7cfd6141830e6138
treee98e2fbd2bb7580ebe59b522b92ac4145073f992
parent63cb2f1f53f1d9f105d123e1a5198b3bce3d8355
usb: gadget: pch_udc: Fix wrong return value

BugLink: http://bugs.launchpad.net/bugs/987337

commit c802672cd36cd063bfd54d54c8c34825ab5b2357 upstream.

ISSUE:
If the return value of pch_udc_pcd_init() is False, the return value of
this function is unsettled.
Since pch_udc_pcd_init() always returns 0, there is not actually the issue.

CAUSE:
If pch_udc_pcd_init() is True, the variable, retval, is not set for an
appropriate value.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/usb/gadget/pch_udc.c