cred: copy_process() should clear child->replacement_session_keyring
authorOleg Nesterov <oleg@redhat.com>
Mon, 9 Apr 2012 19:03:50 +0000 (21:03 +0200)
committerLuis Henriques <luis.henriques@canonical.com>
Mon, 30 Apr 2012 18:15:04 +0000 (19:15 +0100)
commit3208c904261e5b8cbc0da8b3f14aa684778264f7
tree89719d1a2869d170ed074bd19c4d98a27b572ffd
parent8b98b02b3084741a7f830dfe6f72abf5949314a3
cred: copy_process() should clear child->replacement_session_keyring

BugLink: http://bugs.launchpad.net/bugs/981162

commit 79549c6dfda0603dba9a70a53467ce62d9335c33 upstream.

keyctl_session_to_parent(task) sets ->replacement_session_keyring,
it should be processed and cleared by key_replace_session_keyring().

However, this task can fork before it notices TIF_NOTIFY_RESUME and
the new child gets the bogus ->replacement_session_keyring copied by
dup_task_struct(). This is obviously wrong and, if nothing else, this
leads to put_cred(already_freed_cred).

change copy_creds() to clear this member. If copy_process() fails
before this point the wrong ->replacement_session_keyring doesn't
matter, exit_creds() won't be called.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
kernel/cred.c