block: eliminate potential for infinite loop in blkdev_issue_discard
authorMike Snitzer <snitzer@redhat.com>
Wed, 6 Jul 2011 19:30:50 +0000 (21:30 +0200)
committerJens Axboe <jaxboe@fusionio.com>
Wed, 6 Jul 2011 19:32:02 +0000 (21:32 +0200)
commit0f79960391a5a1e3679956024e18aeeb0369ac44
tree4b7e1f7a2b24f3307259024a5f29dbdc0f8b7bd2
parent390192b300570b2bc721d77067ca133f58015ae8
block: eliminate potential for infinite loop in blkdev_issue_discard

Due to the recently identified overflow in read_capacity_16() it was
possible for max_discard_sectors to be zero but still have discards
enabled on the associated device's queue.

Eliminate the possibility for blkdev_issue_discard to infinitely loop.

Interestingly this issue wasn't identified until a device, whose
discard_granularity was 0 due to read_capacity_16 overflow, was consumed
by blk_stack_limits() to construct limits for a higher-level DM
multipath device.  The multipath device's resulting limits never had the
discard limits stacked because blk_stack_limits() will only do so if
the bottom device's discard_granularity != 0.  This resulted in the
multipath device's limits.max_discard_sectors being 0.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
block/blk-lib.c