igmp: call ip_mc_clear_src() only when we have no users of ip_mc_list
authorVeaceslav Falico <vfalico@redhat.com>
Mon, 23 May 2011 23:15:05 +0000 (23:15 +0000)
committerSteve Conklin <sconklin@canonical.com>
Fri, 15 Jul 2011 17:20:57 +0000 (12:20 -0500)
commitfc30ccd04f90a78e6a354b851792b243b27e2ee7
tree077f2f1e9eaacf5721ad2b4f3c35802a238c0f5e
parentbb9e4e08ecd3a34b21e352b1785d0e3311c2cb43
igmp: call ip_mc_clear_src() only when we have no users of ip_mc_list

BugLink: http://bugs.launchpad.net/bugs/793702

[ Upstream commit 24cf3af3fed5edcf90bc2a0ed181e6ce1513d2dc ]

In igmp_group_dropped() we call ip_mc_clear_src(), which resets the number
of source filters per mulitcast. However, igmp_group_dropped() is also
called on NETDEV_DOWN, NETDEV_PRE_TYPE_CHANGE and NETDEV_UNREGISTER, which
means that the group might get added back on NETDEV_UP, NETDEV_REGISTER and
NETDEV_POST_TYPE_CHANGE respectively, leaving us with broken source
filters.

To fix that, we must clear the source filters only when there are no users
in the ip_mc_list, i.e. in ip_mc_dec_group() and on device destroy.

Acked-by: David L Stevens <dlstevens@us.ibm.com>
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
net/ipv4/igmp.c