x86, hw_breakpoints: Fix racy access to ptrace breakpoints
authorFrederic Weisbecker <fweisbec@gmail.com>
Fri, 8 Apr 2011 15:29:36 +0000 (17:29 +0200)
committerSteve Conklin <sconklin@canonical.com>
Thu, 2 Jun 2011 19:23:20 +0000 (14:23 -0500)
commitc964d8426b1ab6d3be20fc98c1c20c2a50ece4af
tree97ca8231a3c18f961758005cbfec30e39cae1791
parent1f7bc57d26e9ab458b24aee3faa50b64aa5dff1c
x86, hw_breakpoints: Fix racy access to ptrace breakpoints

BugLink: http://bugs.launchpad.net/bugs/788691

commit 87dc669ba25777b67796d7262c569429e58b1ed4 upstream.

While the tracer accesses ptrace breakpoints, the child task may
concurrently exit due to a SIGKILL and thus release its breakpoints
at the same time. We can then dereference some freed pointers.

To fix this, hold a reference on the child breakpoints before
manipulating them.

Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Prasad <prasad@linux.vnet.ibm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Link: http://lkml.kernel.org/r/1302284067-7860-3-git-send-email-fweisbec@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Steve Conklin <sconklin@canonical.com>
arch/x86/kernel/ptrace.c