jbd: Fix forever sleeping process in do_get_write_access()
authorJan Kara <jack@suse.cz>
Thu, 5 May 2011 11:59:35 +0000 (13:59 +0200)
committerSteve Conklin <sconklin@canonical.com>
Fri, 15 Jul 2011 17:20:54 +0000 (12:20 -0500)
commitba12d84a956ff4dd6dc5077b3d1a14b143d6f060
treed373ec0fe538938de1f033f4d8d2c0e1558e1596
parent1e93e95ab9667bc9247f5ffe8d21b48d23dbfc1f
jbd: Fix forever sleeping process in do_get_write_access()

BugLink: http://bugs.launchpad.net/bugs/793702

commit 2842bb20eed2e25cde5114298edc62c8883a1d9a upstream.

In do_get_write_access() we wait on BH_Unshadow bit for buffer to get
from shadow state. The waking code in journal_commit_transaction() has
a bug because it does not issue a memory barrier after the buffer is moved
from the shadow state and before wake_up_bit() is called. Thus a waitqueue
check can happen before the buffer is actually moved from the shadow state
and waiting process may never be woken. Fix the problem by issuing proper
barrier.

Reported-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
fs/jbd/commit.c