quota: Don't write quota info in dquot_commit()
authorJan Kara <jack@suse.cz>
Thu, 31 Mar 2011 16:36:52 +0000 (18:36 +0200)
committerBrad Figg <brad.figg@canonical.com>
Wed, 27 Apr 2011 18:41:05 +0000 (11:41 -0700)
commitb7ed535cc0508fd01845f06fad3cc853e17323b6
tree0c4c9d1e1a670f3c174ae9d90b21a9ca73ad0b43
parent0dd33136998851bc59c77f93b137a68c95b73f4e
quota: Don't write quota info in dquot_commit()

BugLink: http://bugs.launchpad.net/bugs/761134

commit b03f24567ce7caf2420b8be4c6eb74c191d59a91 upstream.

There's no reason to write quota info in dquot_commit(). The writing is a
relict from the old days when we didn't have dquot_acquire() and
dquot_release() and thus dquot_commit() could have created / removed quota
structures from the file. These days dquot_commit() only updates usage counters
/ limits in quota structure and thus there's no need to write quota info.

This also fixes an issue with journaling filesystem which didn't reserve
enough space in the transaction for write of quota info (it could have been
dirty at the time of dquot_commit() because of a race with other operation
changing it).

Reported-and-tested-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
fs/quota/dquot.c