sch_sfq: avoid giving spurious NET_XMIT_CN signals
authorEric Dumazet <eric.dumazet@gmail.com>
Mon, 23 May 2011 11:02:42 +0000 (11:02 +0000)
committerSteve Conklin <sconklin@canonical.com>
Fri, 15 Jul 2011 17:20:58 +0000 (12:20 -0500)
commitb0afbe7402f8f71d96d3ad9acaefba8e3de390b9
tree9274a1181d42d2914cd2604d2db09b58046992f4
parentfc0e8dacce6bf75898134727ef208980f159c471
sch_sfq: avoid giving spurious NET_XMIT_CN signals

BugLink: http://bugs.launchpad.net/bugs/793702

[ Upstream commit 8efa885406359af300d46910642b50ca82c0fe47 ]

While chasing a possible net_sched bug, I found that IP fragments have
litle chance to pass a congestioned SFQ qdisc :

- Say SFQ qdisc is full because one flow is non responsive.
- ip_fragment() wants to send two fragments belonging to an idle flow.
- sfq_enqueue() queues first packet, but see queue limit reached :
- sfq_enqueue() drops one packet from 'big consumer', and returns
NET_XMIT_CN.
- ip_fragment() cancel remaining fragments.

This patch restores fairness, making sure we return NET_XMIT_CN only if
we dropped a packet from the same flow.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Patrick McHardy <kaber@trash.net>
CC: Jarek Poplawski <jarkao2@gmail.com>
CC: Jamal Hadi Salim <hadi@cyberus.ca>
CC: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
net/sched/sch_sfq.c