irda: prevent heap corruption on invalid nickname
authorDan Rosenberg <drosenberg@vsecurity.com>
Sat, 19 Mar 2011 20:14:30 +0000 (20:14 +0000)
committerBrad Figg <brad.figg@canonical.com>
Wed, 27 Apr 2011 18:40:42 +0000 (11:40 -0700)
commit713fd62d886c839bb3991c26d95714be01dd6ab7
tree9753b1a4c09616e72c90f8b589d8569f7917a575
parentb86ab3ca479e19de0fb71297bb539c63f8edce22
irda: prevent heap corruption on invalid nickname

BugLink: http://bugs.launchpad.net/bugs/761134

commit d50e7e3604778bfc2dc40f440e0742dbae399d54 upstream.

Invalid nicknames containing only spaces will result in an underflow in
a memcpy size calculation, subsequently destroying the heap and
panicking.

v2 also catches the case where the provided nickname is longer than the
buffer size, which can result in controllable heap corruption.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
net/irda/irnet/irnet_ppp.c