dccp: handle invalid feature options length
authorDan Rosenberg <drosenberg@vsecurity.com>
Fri, 6 May 2011 03:27:18 +0000 (03:27 +0000)
committerSteve Conklin <sconklin@canonical.com>
Thu, 2 Jun 2011 19:23:22 +0000 (14:23 -0500)
commit673edf21bf8f6586ab7d7cf8444a7e553f4833d0
tree3f5be6d018272b8a1bcb84deba39dc4ecddad7d8
parentc65641db0bd4f875c752efe5903fed32bb7eb616
dccp: handle invalid feature options length

BugLink: http://bugs.launchpad.net/bugs/788691

commit a294865978b701e4d0d90135672749531b9a900d upstream.

A length of zero (after subtracting two for the type and len fields) for
the DCCPO_{CHANGE,CONFIRM}_{L,R} options will cause an underflow due to
the subtraction.  The subsequent code may read past the end of the
options value buffer when parsing.  I'm unsure of what the consequences
of this might be, but it's probably not good.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Steve Conklin <sconklin@canonical.com>
net/dccp/options.c