smack: opt_dentry is never null in in smack_d_instantiate()
authorDan Carpenter <error27@gmail.com>
Tue, 1 Jun 2010 07:14:04 +0000 (09:14 +0200)
committerJames Morris <jmorris@namei.org>
Mon, 2 Aug 2010 05:33:39 +0000 (15:33 +1000)
commit3e62cbb8436f6c0cb799c8b7f106de7f662a7b8d
treed36565a4a6f7e0372a1fd9a8750b005635c9c335
parentc3ef1500ec833890275172c7d063333404b64d60
smack: opt_dentry is never null in in smack_d_instantiate()

This patch removes some unneeded code for if opt_dentry is null because
that can never happen.

The function dereferences "opt_dentry" earlier when it checks
"if (opt_dentry->d_parent == opt_dentry) {".  That code was added in
2008.

This function called from security_d_instantiate().  I checked all the
places which call security_d_instantiate() and dentry is always non-null.
I also checked the selinux version of this hook and there is a comment
which says that dentry should be non-null if called from
d_instantiate().

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: James Morris <jmorris@namei.org>
security/smack/smack_lsm.c