bridge: Fix possibly wrong MLD queries' ethernet source address
authorLinus Lüssing <linus.luessing@web.de>
Tue, 22 Mar 2011 11:40:32 +0000 (11:40 +0000)
committerBrad Figg <brad.figg@canonical.com>
Wed, 27 Apr 2011 18:41:53 +0000 (11:41 -0700)
commit1c7b63998f10b0af915641268bcabca7db3b47bb
tree97ac48029a80b132635b528656d7d2142a1d21ac
parent0b09bca7c7201073b932cf65f2dc32ac40819c21
bridge: Fix possibly wrong MLD queries' ethernet source address

BugLink: http://bugs.launchpad.net/bugs/769042

[ Upstream commit a7bff75b087e7a355838a32efe61707cfa73c194 ]

The ipv6_dev_get_saddr() is currently called with an uninitialized
destination address. Although in tests it usually seemed to nevertheless
always fetch the right source address, there seems to be a possible race
condition.

Therefore this commit changes this, first setting the destination
address and only after that fetching the source address.

Reported-by: Jan Beulich <JBeulich@novell.com>
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
net/bridge/br_multicast.c