Revert "ath9k: use split rx buffers to get rid of order-1 skb allocations"
[linux-flexiantxendom0-natty.git] / drivers / net / wireless / ath / ath9k / main.c
index df1bfcf..0848e09 100644 (file)
@@ -15,7 +15,6 @@
  */
 
 #include <linux/nl80211.h>
-#include <linux/pm_qos_params.h>
 #include "ath9k.h"
 #include "btcoex.h"
 
@@ -247,9 +246,10 @@ int ath_set_channel(struct ath_softc *sc, struct ieee80211_hw *hw,
         * the relevant bits of the h/w.
         */
        ath9k_hw_disable_interrupts(ah);
-       ath_drain_all_txq(sc, false);
+       stopped = ath_drain_all_txq(sc, false);
 
-       stopped = ath_stoprecv(sc);
+       if (!ath_stoprecv(sc))
+               stopped = false;
 
        /* XXX: do not flush receive queue here. We don't want
         * to flush data frames already in queue because of
@@ -261,24 +261,22 @@ int ath_set_channel(struct ath_softc *sc, struct ieee80211_hw *hw,
        if (!(sc->sc_flags & SC_OP_OFFCHANNEL))
                caldata = &aphy->caldata;
 
-       ath_print(common, ATH_DBG_CONFIG,
-                 "(%u MHz) -> (%u MHz), conf_is_ht40: %d fastcc: %d\n",
-                 sc->sc_ah->curchan->channel,
-                 channel->center_freq, conf_is_ht40(conf),
-                 fastcc);
+       ath_dbg(common, ATH_DBG_CONFIG,
+               "(%u MHz) -> (%u MHz), conf_is_ht40: %d fastcc: %d\n",
+               sc->sc_ah->curchan->channel,
+               channel->center_freq, conf_is_ht40(conf),
+               fastcc);
 
        r = ath9k_hw_reset(ah, hchan, caldata, fastcc);
        if (r) {
-               ath_print(common, ATH_DBG_FATAL,
-                         "Unable to reset channel (%u MHz), "
-                         "reset status %d\n",
-                         channel->center_freq, r);
+               ath_err(common,
+                       "Unable to reset channel (%u MHz), reset status %d\n",
+                       channel->center_freq, r);
                goto ps_restore;
        }
 
        if (ath_startrecv(sc) != 0) {
-               ath_print(common, ATH_DBG_FATAL,
-                         "Unable to restart recv logic\n");
+               ath_err(common, "Unable to restart recv logic\n");
                r = -EIO;
                goto ps_restore;
        }
@@ -287,7 +285,8 @@ int ath_set_channel(struct ath_softc *sc, struct ieee80211_hw *hw,
        ath9k_hw_set_interrupts(ah, ah->imask);
 
        if (!(sc->sc_flags & (SC_OP_OFFCHANNEL))) {
-               ath_beacon_config(sc, NULL);
+               if (sc->sc_flags & SC_OP_BEACONS)
+                       ath_beacon_config(sc, NULL);
                ieee80211_queue_delayed_work(sc->hw, &sc->tx_complete_work, 0);
                ath_start_ani(common);
        }
@@ -322,6 +321,46 @@ static void ath_paprd_activate(struct ath_softc *sc)
        ath9k_ps_restore(sc);
 }
 
+static bool ath_paprd_send_frame(struct ath_softc *sc, struct sk_buff *skb, int chain)
+{
+       struct ieee80211_hw *hw = sc->hw;
+       struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
+       struct ath_hw *ah = sc->sc_ah;
+       struct ath_common *common = ath9k_hw_common(ah);
+       struct ath_tx_control txctl;
+       int time_left;
+
+       memset(&txctl, 0, sizeof(txctl));
+       txctl.txq = sc->tx.txq_map[WME_AC_BE];
+
+       memset(tx_info, 0, sizeof(*tx_info));
+       tx_info->band = hw->conf.channel->band;
+       tx_info->flags |= IEEE80211_TX_CTL_NO_ACK;
+       tx_info->control.rates[0].idx = 0;
+       tx_info->control.rates[0].count = 1;
+       tx_info->control.rates[0].flags = IEEE80211_TX_RC_MCS;
+       tx_info->control.rates[1].idx = -1;
+
+       init_completion(&sc->paprd_complete);
+       txctl.paprd = BIT(chain);
+
+       if (ath_tx_start(hw, skb, &txctl) != 0) {
+               ath_dbg(common, ATH_DBG_XMIT, "PAPRD TX failed\n");
+               dev_kfree_skb_any(skb);
+               return false;
+       }
+
+       time_left = wait_for_completion_timeout(&sc->paprd_complete,
+                       msecs_to_jiffies(ATH_PAPRD_TIMEOUT));
+
+       if (!time_left)
+               ath_dbg(ath9k_hw_common(sc->sc_ah), ATH_DBG_CALIBRATE,
+                       "Timeout waiting for paprd training on TX chain %d\n",
+                       chain);
+
+       return !!time_left;
+}
+
 void ath_paprd_calibrate(struct work_struct *work)
 {
        struct ath_softc *sc = container_of(work, struct ath_softc, paprd_work);
@@ -329,28 +368,23 @@ void ath_paprd_calibrate(struct work_struct *work)
        struct ath_hw *ah = sc->sc_ah;
        struct ieee80211_hdr *hdr;
        struct sk_buff *skb = NULL;
-       struct ieee80211_tx_info *tx_info;
-       int band = hw->conf.channel->band;
-       struct ieee80211_supported_band *sband = &sc->sbands[band];
-       struct ath_tx_control txctl;
        struct ath9k_hw_cal_data *caldata = ah->caldata;
        struct ath_common *common = ath9k_hw_common(ah);
        int ftype;
        int chain_ok = 0;
        int chain;
        int len = 1800;
-       int time_left;
-       int i;
 
        if (!caldata)
                return;
 
+       if (ar9003_paprd_init_table(ah) < 0)
+               return;
+
        skb = alloc_skb(len, GFP_KERNEL);
        if (!skb)
                return;
 
-       tx_info = IEEE80211_SKB_CB(skb);
-
        skb_put(skb, len);
        memset(skb->data, 0, len);
        hdr = (struct ieee80211_hdr *)skb->data;
@@ -361,41 +395,25 @@ void ath_paprd_calibrate(struct work_struct *work)
        memcpy(hdr->addr2, hw->wiphy->perm_addr, ETH_ALEN);
        memcpy(hdr->addr3, hw->wiphy->perm_addr, ETH_ALEN);
 
-       memset(&txctl, 0, sizeof(txctl));
-       txctl.txq = sc->tx.txq_map[WME_AC_BE];
-
        ath9k_ps_wakeup(sc);
-       ar9003_paprd_init_table(ah);
        for (chain = 0; chain < AR9300_MAX_CHAINS; chain++) {
                if (!(common->tx_chainmask & BIT(chain)))
                        continue;
 
                chain_ok = 0;
-               memset(tx_info, 0, sizeof(*tx_info));
-               tx_info->band = band;
 
-               for (i = 0; i < 4; i++) {
-                       tx_info->control.rates[i].idx = sband->n_bitrates - 1;
-                       tx_info->control.rates[i].count = 6;
-               }
+               ath_dbg(common, ATH_DBG_CALIBRATE,
+                       "Sending PAPRD frame for thermal measurement "
+                       "on chain %d\n", chain);
+               if (!ath_paprd_send_frame(sc, skb, chain))
+                       goto fail_paprd;
 
-               init_completion(&sc->paprd_complete);
-               sc->paprd_pending = true;
                ar9003_paprd_setup_gain_table(ah, chain);
-               txctl.paprd = BIT(chain);
-               if (ath_tx_start(hw, skb, &txctl) != 0)
-                       break;
 
-               time_left = wait_for_completion_timeout(&sc->paprd_complete,
-                               msecs_to_jiffies(ATH_PAPRD_TIMEOUT));
-               sc->paprd_pending = false;
-               if (!time_left) {
-                       ath_print(ath9k_hw_common(ah), ATH_DBG_CALIBRATE,
-                                 "Timeout waiting for paprd training on "
-                                 "TX chain %d\n",
-                                 chain);
+               ath_dbg(common, ATH_DBG_CALIBRATE,
+                       "Sending PAPRD training frame on chain %d\n", chain);
+               if (!ath_paprd_send_frame(sc, skb, chain))
                        goto fail_paprd;
-               }
 
                if (!ar9003_paprd_is_done(ah))
                        break;
@@ -452,7 +470,7 @@ void ath_ani_calibrate(unsigned long data)
        /* Long calibration runs independently of short calibration. */
        if ((timestamp - common->ani.longcal_timer) >= long_cal_interval) {
                longcal = true;
-               ath_print(common, ATH_DBG_ANI, "longcal @%lu\n", jiffies);
+               ath_dbg(common, ATH_DBG_ANI, "longcal @%lu\n", jiffies);
                common->ani.longcal_timer = timestamp;
        }
 
@@ -460,8 +478,8 @@ void ath_ani_calibrate(unsigned long data)
        if (!common->ani.caldone) {
                if ((timestamp - common->ani.shortcal_timer) >= short_cal_interval) {
                        shortcal = true;
-                       ath_print(common, ATH_DBG_ANI,
-                                 "shortcal @%lu\n", jiffies);
+                       ath_dbg(common, ATH_DBG_ANI,
+                               "shortcal @%lu\n", jiffies);
                        common->ani.shortcal_timer = timestamp;
                        common->ani.resetcal_timer = timestamp;
                }
@@ -520,37 +538,11 @@ set_timer:
        if ((sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_PAPRD) && ah->caldata) {
                if (!ah->caldata->paprd_done)
                        ieee80211_queue_work(sc->hw, &sc->paprd_work);
-               else
+               else if (!ah->paprd_table_write_done)
                        ath_paprd_activate(sc);
        }
 }
 
-/*
- * Update tx/rx chainmask. For legacy association,
- * hard code chainmask to 1x1, for 11n association, use
- * the chainmask configuration, for bt coexistence, use
- * the chainmask configuration even in legacy mode.
- */
-void ath_update_chainmask(struct ath_softc *sc, int is_ht)
-{
-       struct ath_hw *ah = sc->sc_ah;
-       struct ath_common *common = ath9k_hw_common(ah);
-
-       if ((sc->sc_flags & SC_OP_OFFCHANNEL) || is_ht ||
-           (ah->btcoex_hw.scheme != ATH_BTCOEX_CFG_NONE)) {
-               common->tx_chainmask = ah->caps.tx_chainmask;
-               common->rx_chainmask = ah->caps.rx_chainmask;
-       } else {
-               common->tx_chainmask = 1;
-               common->rx_chainmask = 1;
-       }
-
-       ath_print(common, ATH_DBG_CONFIG,
-                 "tx chmask: %d, rx chmask: %d\n",
-                 common->tx_chainmask,
-                 common->rx_chainmask);
-}
-
 static void ath_node_attach(struct ath_softc *sc, struct ieee80211_sta *sta)
 {
        struct ath_node *an;
@@ -604,15 +596,13 @@ void ath9k_tasklet(unsigned long data)
        u32 status = sc->intrstatus;
        u32 rxmask;
 
-       ath9k_ps_wakeup(sc);
-
        if (status & ATH9K_INT_FATAL) {
                ath_reset(sc, true);
-               ath9k_ps_restore(sc);
                return;
        }
 
-       spin_lock_bh(&sc->sc_pcu_lock);
+       ath9k_ps_wakeup(sc);
+       spin_lock(&sc->sc_pcu_lock);
 
        if (!ath9k_hw_check_alive(ah))
                ieee80211_queue_work(sc->hw, &sc->hw_check_work);
@@ -644,8 +634,8 @@ void ath9k_tasklet(unsigned long data)
                 * TSF sync does not look correct; remain awake to sync with
                 * the next Beacon.
                 */
-               ath_print(common, ATH_DBG_PS,
-                         "TSFOOR - Sync with next Beacon\n");
+               ath_dbg(common, ATH_DBG_PS,
+                       "TSFOOR - Sync with next Beacon\n");
                sc->ps_flags |= PS_WAIT_FOR_BEACON | PS_BEACON_SYNC;
        }
 
@@ -656,7 +646,7 @@ void ath9k_tasklet(unsigned long data)
        /* re-enable hardware interrupt */
        ath9k_hw_enable_interrupts(ah);
 
-       spin_unlock_bh(&sc->sc_pcu_lock);
+       spin_unlock(&sc->sc_pcu_lock);
        ath9k_ps_restore(sc);
 }
 
@@ -769,6 +759,8 @@ irqreturn_t ath_isr(int irq, void *dev)
 
        if (!(ah->caps.hw_caps & ATH9K_HW_CAP_AUTOSLEEP))
                if (status & ATH9K_INT_TIM_TIMER) {
+                       if (ATH_DBG_WARN_ON_ONCE(sc->ps_idle))
+                               goto chip_reset;
                        /* Clear RxAbort bit so that we can
                         * receive frames */
                        ath9k_setpower(sc, ATH9K_PM_AWAKE);
@@ -843,9 +835,9 @@ static void ath9k_bss_assoc_info(struct ath_softc *sc,
        struct ath_common *common = ath9k_hw_common(ah);
 
        if (bss_conf->assoc) {
-               ath_print(common, ATH_DBG_CONFIG,
-                         "Bss Info ASSOC %d, bssid: %pM\n",
-                          bss_conf->aid, common->curbssid);
+               ath_dbg(common, ATH_DBG_CONFIG,
+                       "Bss Info ASSOC %d, bssid: %pM\n",
+                       bss_conf->aid, common->curbssid);
 
                /* New association, store aid */
                common->curaid = bss_conf->aid;
@@ -868,7 +860,7 @@ static void ath9k_bss_assoc_info(struct ath_softc *sc,
                sc->sc_flags |= SC_OP_ANI_RUN;
                ath_start_ani(common);
        } else {
-               ath_print(common, ATH_DBG_CONFIG, "Bss Info DISASSOC\n");
+               ath_dbg(common, ATH_DBG_CONFIG, "Bss Info DISASSOC\n");
                common->curaid = 0;
                /* Stop ANI */
                sc->sc_flags &= ~SC_OP_ANI_RUN;
@@ -893,18 +885,15 @@ void ath_radio_enable(struct ath_softc *sc, struct ieee80211_hw *hw)
 
        r = ath9k_hw_reset(ah, ah->curchan, ah->caldata, false);
        if (r) {
-               ath_print(common, ATH_DBG_FATAL,
-                         "Unable to reset channel (%u MHz), "
-                         "reset status %d\n",
-                         channel->center_freq, r);
+               ath_err(common,
+                       "Unable to reset channel (%u MHz), reset status %d\n",
+                       channel->center_freq, r);
        }
 
        ath_update_txpow(sc);
        if (ath_startrecv(sc) != 0) {
-               ath_print(common, ATH_DBG_FATAL,
-                         "Unable to restart recv logic\n");
-               spin_unlock_bh(&sc->sc_pcu_lock);
-               return;
+               ath_err(common, "Unable to restart recv logic\n");
+               goto out;
        }
        if (sc->sc_flags & SC_OP_BEACONS)
                ath_beacon_config(sc, NULL);    /* restart beacons */
@@ -918,6 +907,7 @@ void ath_radio_enable(struct ath_softc *sc, struct ieee80211_hw *hw)
        ath9k_hw_set_gpio(ah, ah->led_pin, 0);
 
        ieee80211_wake_queues(hw);
+out:
        spin_unlock_bh(&sc->sc_pcu_lock);
 
        ath9k_ps_restore(sc);
@@ -956,10 +946,9 @@ void ath_radio_disable(struct ath_softc *sc, struct ieee80211_hw *hw)
 
        r = ath9k_hw_reset(ah, ah->curchan, ah->caldata, false);
        if (r) {
-               ath_print(ath9k_hw_common(sc->sc_ah), ATH_DBG_FATAL,
-                         "Unable to reset channel (%u MHz), "
-                         "reset status %d\n",
-                         channel->center_freq, r);
+               ath_err(ath9k_hw_common(sc->sc_ah),
+                       "Unable to reset channel (%u MHz), reset status %d\n",
+                       channel->center_freq, r);
        }
 
        ath9k_hw_phy_disable(ah);
@@ -968,8 +957,6 @@ void ath_radio_disable(struct ath_softc *sc, struct ieee80211_hw *hw)
 
        spin_unlock_bh(&sc->sc_pcu_lock);
        ath9k_ps_restore(sc);
-
-       ath9k_setpower(sc, ATH9K_PM_FULL_SLEEP);
 }
 
 int ath_reset(struct ath_softc *sc, bool retry_tx)
@@ -982,6 +969,7 @@ int ath_reset(struct ath_softc *sc, bool retry_tx)
        /* Stop ANI */
        del_timer_sync(&common->ani.timer);
 
+       ath9k_ps_wakeup(sc);
        spin_lock_bh(&sc->sc_pcu_lock);
 
        ieee80211_stop_queues(hw);
@@ -994,12 +982,11 @@ int ath_reset(struct ath_softc *sc, bool retry_tx)
 
        r = ath9k_hw_reset(ah, sc->sc_ah->curchan, ah->caldata, false);
        if (r)
-               ath_print(common, ATH_DBG_FATAL,
-                         "Unable to reset hardware; reset status %d\n", r);
+               ath_err(common,
+                       "Unable to reset hardware; reset status %d\n", r);
 
        if (ath_startrecv(sc) != 0)
-               ath_print(common, ATH_DBG_FATAL,
-                         "Unable to start recv logic\n");
+               ath_err(common, "Unable to start recv logic\n");
 
        /*
         * We may be doing a reset in response to a request
@@ -1029,6 +1016,7 @@ int ath_reset(struct ath_softc *sc, bool retry_tx)
 
        /* Start ANI */
        ath_start_ani(common);
+       ath9k_ps_restore(sc);
 
        return r;
 }
@@ -1071,9 +1059,11 @@ static int ath9k_start(struct ieee80211_hw *hw)
        struct ath9k_channel *init_channel;
        int r;
 
-       ath_print(common, ATH_DBG_CONFIG,
-                 "Starting driver with initial channel: %d MHz\n",
-                 curchan->center_freq);
+       ath_dbg(common, ATH_DBG_CONFIG,
+               "Starting driver with initial channel: %d MHz\n",
+               curchan->center_freq);
+
+       ath9k_ps_wakeup(sc);
 
        mutex_lock(&sc->mutex);
 
@@ -1117,10 +1107,9 @@ static int ath9k_start(struct ieee80211_hw *hw)
        spin_lock_bh(&sc->sc_pcu_lock);
        r = ath9k_hw_reset(ah, init_channel, ah->caldata, false);
        if (r) {
-               ath_print(common, ATH_DBG_FATAL,
-                         "Unable to reset hardware; reset status %d "
-                         "(freq %u MHz)\n", r,
-                         curchan->center_freq);
+               ath_err(common,
+                       "Unable to reset hardware; reset status %d (freq %u MHz)\n",
+                       r, curchan->center_freq);
                spin_unlock_bh(&sc->sc_pcu_lock);
                goto mutex_unlock;
        }
@@ -1139,8 +1128,7 @@ static int ath9k_start(struct ieee80211_hw *hw)
         * here except setup the interrupt mask.
         */
        if (ath_startrecv(sc) != 0) {
-               ath_print(common, ATH_DBG_FATAL,
-                         "Unable to start recv logic\n");
+               ath_err(common, "Unable to start recv logic\n");
                r = -EIO;
                spin_unlock_bh(&sc->sc_pcu_lock);
                goto mutex_unlock;
@@ -1187,11 +1175,14 @@ static int ath9k_start(struct ieee80211_hw *hw)
                        ath9k_btcoex_timer_resume(sc);
        }
 
-       pm_qos_update_request(&ath9k_pm_qos_req, 55);
+       if (ah->caps.pcie_lcr_extsync_en && common->bus_ops->extn_synch_en)
+               common->bus_ops->extn_synch_en(common);
 
 mutex_unlock:
        mutex_unlock(&sc->mutex);
 
+       ath9k_ps_restore(sc);
+
        return r;
 }
 
@@ -1205,9 +1196,9 @@ static int ath9k_tx(struct ieee80211_hw *hw,
        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
 
        if (aphy->state != ATH_WIPHY_ACTIVE && aphy->state != ATH_WIPHY_SCAN) {
-               ath_print(common, ATH_DBG_XMIT,
-                         "ath9k: %s: TX in unexpected wiphy state "
-                         "%d\n", wiphy_name(hw->wiphy), aphy->state);
+               ath_dbg(common, ATH_DBG_XMIT,
+                       "ath9k: %s: TX in unexpected wiphy state %d\n",
+                       wiphy_name(hw->wiphy), aphy->state);
                goto exit;
        }
 
@@ -1219,8 +1210,8 @@ static int ath9k_tx(struct ieee80211_hw *hw,
                if (ieee80211_is_data(hdr->frame_control) &&
                    !ieee80211_is_nullfunc(hdr->frame_control) &&
                    !ieee80211_has_pm(hdr->frame_control)) {
-                       ath_print(common, ATH_DBG_PS, "Add PM=1 for a TX frame "
-                                 "while in PS mode\n");
+                       ath_dbg(common, ATH_DBG_PS,
+                               "Add PM=1 for a TX frame while in PS mode\n");
                        hdr->frame_control |= cpu_to_le16(IEEE80211_FCTL_PM);
                }
        }
@@ -1235,12 +1226,12 @@ static int ath9k_tx(struct ieee80211_hw *hw,
                if (!(sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_AUTOSLEEP))
                        ath9k_hw_setrxabort(sc->sc_ah, 0);
                if (ieee80211_is_pspoll(hdr->frame_control)) {
-                       ath_print(common, ATH_DBG_PS,
-                                 "Sending PS-Poll to pick a buffered frame\n");
+                       ath_dbg(common, ATH_DBG_PS,
+                               "Sending PS-Poll to pick a buffered frame\n");
                        sc->ps_flags |= PS_WAIT_FOR_PSPOLL_DATA;
                } else {
-                       ath_print(common, ATH_DBG_PS,
-                                 "Wake up to complete TX\n");
+                       ath_dbg(common, ATH_DBG_PS,
+                               "Wake up to complete TX\n");
                        sc->ps_flags |= PS_WAIT_FOR_TX_ACK;
                }
                /*
@@ -1254,10 +1245,10 @@ static int ath9k_tx(struct ieee80211_hw *hw,
        memset(&txctl, 0, sizeof(struct ath_tx_control));
        txctl.txq = sc->tx.txq_map[skb_get_queue_mapping(skb)];
 
-       ath_print(common, ATH_DBG_XMIT, "transmitting packet, skb: %p\n", skb);
+       ath_dbg(common, ATH_DBG_XMIT, "transmitting packet, skb: %p\n", skb);
 
        if (ath_tx_start(hw, skb, &txctl) != 0) {
-               ath_print(common, ATH_DBG_XMIT, "TX failed\n");
+               ath_dbg(common, ATH_DBG_XMIT, "TX failed\n");
                goto exit;
        }
 
@@ -1297,7 +1288,7 @@ static void ath9k_stop(struct ieee80211_hw *hw)
        }
 
        if (sc->sc_flags & SC_OP_INVALID) {
-               ath_print(common, ATH_DBG_ANY, "Device not present\n");
+               ath_dbg(common, ATH_DBG_ANY, "Device not present\n");
                mutex_unlock(&sc->mutex);
                return;
        }
@@ -1318,6 +1309,9 @@ static void ath9k_stop(struct ieee80211_hw *hw)
 
        spin_lock_bh(&sc->sc_pcu_lock);
 
+       /* prevent tasklets to enable interrupts once we disable them */
+       ah->imask &= ~ATH9K_INT_GLOBAL;
+
        /* make sure h/w will not generate any interrupt
         * before setting the invalid flag. */
        ath9k_hw_disable_interrupts(ah);
@@ -1335,18 +1329,23 @@ static void ath9k_stop(struct ieee80211_hw *hw)
 
        spin_unlock_bh(&sc->sc_pcu_lock);
 
+       /* we can now sync irq and kill any running tasklets, since we already
+        * disabled interrupts and not holding a spin lock */
+       synchronize_irq(sc->irq);
+       tasklet_kill(&sc->intr_tq);
+       tasklet_kill(&sc->bcon_tasklet);
+
        ath9k_ps_restore(sc);
 
-       /* Finally, put the chip in FULL SLEEP mode */
-       ath9k_setpower(sc, ATH9K_PM_FULL_SLEEP);
+       sc->ps_idle = true;
+       ath9k_set_wiphy_idle(aphy, true);
+       ath_radio_disable(sc, hw);
 
        sc->sc_flags |= SC_OP_INVALID;
 
-       pm_qos_update_request(&ath9k_pm_qos_req, PM_QOS_DEFAULT_VALUE);
-
        mutex_unlock(&sc->mutex);
 
-       ath_print(common, ATH_DBG_CONFIG, "Driver halt\n");
+       ath_dbg(common, ATH_DBG_CONFIG, "Driver halt\n");
 }
 
 static int ath9k_add_interface(struct ieee80211_hw *hw,
@@ -1379,14 +1378,14 @@ static int ath9k_add_interface(struct ieee80211_hw *hw,
                ic_opmode = vif->type;
                break;
        default:
-               ath_print(common, ATH_DBG_FATAL,
-                       "Interface type %d not yet supported\n", vif->type);
+               ath_err(common, "Interface type %d not yet supported\n",
+                       vif->type);
                ret = -EOPNOTSUPP;
                goto out;
        }
 
-       ath_print(common, ATH_DBG_CONFIG,
-                 "Attach a VIF of type: %d\n", ic_opmode);
+       ath_dbg(common, ATH_DBG_CONFIG,
+               "Attach a VIF of type: %d\n", ic_opmode);
 
        /* Set the VIF opmode */
        avp->av_opmode = ic_opmode;
@@ -1432,16 +1431,83 @@ out:
        return ret;
 }
 
+static void ath9k_reclaim_beacon(struct ath_softc *sc,
+                                struct ieee80211_vif *vif)
+{
+       struct ath_vif *avp = (void *)vif->drv_priv;
+
+       /* Disable SWBA interrupt */
+       sc->sc_ah->imask &= ~ATH9K_INT_SWBA;
+       ath9k_ps_wakeup(sc);
+       ath9k_hw_set_interrupts(sc->sc_ah, sc->sc_ah->imask);
+       ath9k_hw_stoptxdma(sc->sc_ah, sc->beacon.beaconq);
+       tasklet_kill(&sc->bcon_tasklet);
+       ath9k_ps_restore(sc);
+
+       ath_beacon_return(sc, avp);
+       sc->sc_flags &= ~SC_OP_BEACONS;
+
+       if (sc->nbcnvifs > 0) {
+               /* Re-enable beaconing */
+               sc->sc_ah->imask |= ATH9K_INT_SWBA;
+               ath9k_ps_wakeup(sc);
+               ath9k_hw_set_interrupts(sc->sc_ah, sc->sc_ah->imask);
+               ath9k_ps_restore(sc);
+       }
+}
+
+static int ath9k_change_interface(struct ieee80211_hw *hw,
+                                 struct ieee80211_vif *vif,
+                                 enum nl80211_iftype new_type,
+                                 bool p2p)
+{
+       struct ath_wiphy *aphy = hw->priv;
+       struct ath_softc *sc = aphy->sc;
+       struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+       int ret = 0;
+
+       ath_dbg(common, ATH_DBG_CONFIG, "Change Interface\n");
+       mutex_lock(&sc->mutex);
+
+       switch (new_type) {
+       case NL80211_IFTYPE_AP:
+       case NL80211_IFTYPE_ADHOC:
+               if (sc->nbcnvifs >= ATH_BCBUF) {
+                       ath_err(common, "No beacon slot available\n");
+                       ret = -ENOBUFS;
+                       goto out;
+               }
+               break;
+       case NL80211_IFTYPE_STATION:
+               /* Stop ANI */
+               sc->sc_flags &= ~SC_OP_ANI_RUN;
+               del_timer_sync(&common->ani.timer);
+               if ((vif->type == NL80211_IFTYPE_AP) ||
+                   (vif->type == NL80211_IFTYPE_ADHOC))
+                       ath9k_reclaim_beacon(sc, vif);
+               break;
+       default:
+               ath_err(common, "Interface type %d not yet supported\n",
+                               vif->type);
+               ret = -ENOTSUPP;
+               goto out;
+       }
+       vif->type = new_type;
+       vif->p2p = p2p;
+
+out:
+       mutex_unlock(&sc->mutex);
+       return ret;
+}
+
 static void ath9k_remove_interface(struct ieee80211_hw *hw,
                                   struct ieee80211_vif *vif)
 {
        struct ath_wiphy *aphy = hw->priv;
        struct ath_softc *sc = aphy->sc;
        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
-       struct ath_vif *avp = (void *)vif->drv_priv;
-       int i;
 
-       ath_print(common, ATH_DBG_CONFIG, "Detach Interface\n");
+       ath_dbg(common, ATH_DBG_CONFIG, "Detach Interface\n");
 
        mutex_lock(&sc->mutex);
 
@@ -1452,23 +1518,8 @@ static void ath9k_remove_interface(struct ieee80211_hw *hw,
        /* Reclaim beacon resources */
        if ((sc->sc_ah->opmode == NL80211_IFTYPE_AP) ||
            (sc->sc_ah->opmode == NL80211_IFTYPE_ADHOC) ||
-           (sc->sc_ah->opmode == NL80211_IFTYPE_MESH_POINT)) {
-               ath9k_ps_wakeup(sc);
-               ath9k_hw_stoptxdma(sc->sc_ah, sc->beacon.beaconq);
-               ath9k_ps_restore(sc);
-       }
-
-       ath_beacon_return(sc, avp);
-       sc->sc_flags &= ~SC_OP_BEACONS;
-
-       for (i = 0; i < ARRAY_SIZE(sc->beacon.bslot); i++) {
-               if (sc->beacon.bslot[i] == vif) {
-                       printk(KERN_DEBUG "%s: vif had allocated beacon "
-                              "slot\n", __func__);
-                       sc->beacon.bslot[i] = NULL;
-                       sc->beacon.bslot_aphy[i] = NULL;
-               }
-       }
+           (sc->sc_ah->opmode == NL80211_IFTYPE_MESH_POINT))
+               ath9k_reclaim_beacon(sc, vif);
 
        sc->nvifs--;
 
@@ -1548,8 +1599,8 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
                if (enable_radio) {
                        sc->ps_idle = false;
                        ath_radio_enable(sc, hw);
-                       ath_print(common, ATH_DBG_CONFIG,
-                                 "not-idle: enabling radio\n");
+                       ath_dbg(common, ATH_DBG_CONFIG,
+                               "not-idle: enabling radio\n");
                }
        }
 
@@ -1571,12 +1622,12 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
 
        if (changed & IEEE80211_CONF_CHANGE_MONITOR) {
                if (conf->flags & IEEE80211_CONF_MONITOR) {
-                       ath_print(common, ATH_DBG_CONFIG,
-                                 "Monitor mode is enabled\n");
+                       ath_dbg(common, ATH_DBG_CONFIG,
+                               "Monitor mode is enabled\n");
                        sc->sc_ah->is_monitoring = true;
                } else {
-                       ath_print(common, ATH_DBG_CONFIG,
-                                 "Monitor mode is disabled\n");
+                       ath_dbg(common, ATH_DBG_CONFIG,
+                               "Monitor mode is disabled\n");
                        sc->sc_ah->is_monitoring = false;
                }
        }
@@ -1608,14 +1659,12 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
                        goto skip_chan_change;
                }
 
-               ath_print(common, ATH_DBG_CONFIG, "Set channel: %d MHz\n",
-                         curchan->center_freq);
+               ath_dbg(common, ATH_DBG_CONFIG, "Set channel: %d MHz\n",
+                       curchan->center_freq);
 
                /* XXX: remove me eventualy */
                ath9k_update_ichannel(sc, hw, &sc->sc_ah->channels[pos]);
 
-               ath_update_chainmask(sc, conf_is_ht(conf));
-
                /* update survey stats for the old channel before switching */
                spin_lock_irqsave(&common->cc_lock, flags);
                ath_update_survey_stats(sc);
@@ -1642,8 +1691,7 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
                }
 
                if (ath_set_channel(sc, hw, &sc->sc_ah->channels[pos]) < 0) {
-                       ath_print(common, ATH_DBG_FATAL,
-                                 "Unable to set channel\n");
+                       ath_err(common, "Unable to set channel\n");
                        mutex_unlock(&sc->mutex);
                        return -EINVAL;
                }
@@ -1660,7 +1708,9 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
 skip_chan_change:
        if (changed & IEEE80211_CONF_CHANGE_POWER) {
                sc->config.txpowlimit = 2 * conf->power_level;
+               ath9k_ps_wakeup(sc);
                ath_update_txpow(sc);
+               ath9k_ps_restore(sc);
        }
 
        spin_lock_bh(&sc->wiphy_lock);
@@ -1668,7 +1718,7 @@ skip_chan_change:
        spin_unlock_bh(&sc->wiphy_lock);
 
        if (disable_radio) {
-               ath_print(common, ATH_DBG_CONFIG, "idle: disabling radio\n");
+               ath_dbg(common, ATH_DBG_CONFIG, "idle: disabling radio\n");
                sc->ps_idle = true;
                ath_radio_disable(sc, hw);
        }
@@ -1707,8 +1757,8 @@ static void ath9k_configure_filter(struct ieee80211_hw *hw,
        ath9k_hw_setrxfilter(sc->sc_ah, rfilt);
        ath9k_ps_restore(sc);
 
-       ath_print(ath9k_hw_common(sc->sc_ah), ATH_DBG_CONFIG,
-                 "Set HW RX filter: 0x%x\n", rfilt);
+       ath_dbg(ath9k_hw_common(sc->sc_ah), ATH_DBG_CONFIG,
+               "Set HW RX filter: 0x%x\n", rfilt);
 }
 
 static int ath9k_sta_add(struct ieee80211_hw *hw,
@@ -1759,15 +1809,14 @@ static int ath9k_conf_tx(struct ieee80211_hw *hw, u16 queue,
        qi.tqi_cwmax = params->cw_max;
        qi.tqi_burstTime = params->txop;
 
-       ath_print(common, ATH_DBG_CONFIG,
-                 "Configure tx [queue/halq] [%d/%d],  "
-                 "aifs: %d, cw_min: %d, cw_max: %d, txop: %d\n",
-                 queue, txq->axq_qnum, params->aifs, params->cw_min,
-                 params->cw_max, params->txop);
+       ath_dbg(common, ATH_DBG_CONFIG,
+               "Configure tx [queue/halq] [%d/%d], aifs: %d, cw_min: %d, cw_max: %d, txop: %d\n",
+               queue, txq->axq_qnum, params->aifs, params->cw_min,
+               params->cw_max, params->txop);
 
        ret = ath_txq_update(sc, txq->axq_qnum, &qi);
        if (ret)
-               ath_print(common, ATH_DBG_FATAL, "TXQ Update failed\n");
+               ath_err(common, "TXQ Update failed\n");
 
        if (sc->sc_ah->opmode == NL80211_IFTYPE_ADHOC)
                if (queue == WME_AC_BE && !ret)
@@ -1789,12 +1838,12 @@ static int ath9k_set_key(struct ieee80211_hw *hw,
        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
        int ret = 0;
 
-       if (modparam_nohwcrypt)
+       if (ath9k_modparam_nohwcrypt)
                return -ENOSPC;
 
        mutex_lock(&sc->mutex);
        ath9k_ps_wakeup(sc);
-       ath_print(common, ATH_DBG_CONFIG, "Set HW Key\n");
+       ath_dbg(common, ATH_DBG_CONFIG, "Set HW Key\n");
 
        switch (cmd) {
        case SET_KEY:
@@ -1849,13 +1898,8 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
                /* Set aggregation protection mode parameters */
                sc->config.ath_aggr_prot = 0;
 
-               /* Only legacy IBSS for now */
-               if (vif->type == NL80211_IFTYPE_ADHOC)
-                       ath_update_chainmask(sc, 0);
-
-               ath_print(common, ATH_DBG_CONFIG,
-                         "BSSID: %pM aid: 0x%x\n",
-                         common->curbssid, common->curaid);
+               ath_dbg(common, ATH_DBG_CONFIG, "BSSID: %pM aid: 0x%x\n",
+                       common->curbssid, common->curaid);
 
                /* need to reconfigure the beacon */
                sc->sc_flags &= ~SC_OP_BEACONS ;
@@ -1911,8 +1955,8 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
        }
 
        if (changed & BSS_CHANGED_ERP_PREAMBLE) {
-               ath_print(common, ATH_DBG_CONFIG, "BSS Changed PREAMBLE %d\n",
-                         bss_conf->use_short_preamble);
+               ath_dbg(common, ATH_DBG_CONFIG, "BSS Changed PREAMBLE %d\n",
+                       bss_conf->use_short_preamble);
                if (bss_conf->use_short_preamble)
                        sc->sc_flags |= SC_OP_PREAMBLE_SHORT;
                else
@@ -1920,8 +1964,8 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
        }
 
        if (changed & BSS_CHANGED_ERP_CTS_PROT) {
-               ath_print(common, ATH_DBG_CONFIG, "BSS Changed CTS PROT %d\n",
-                         bss_conf->use_cts_prot);
+               ath_dbg(common, ATH_DBG_CONFIG, "BSS Changed CTS PROT %d\n",
+                       bss_conf->use_cts_prot);
                if (bss_conf->use_cts_prot &&
                    hw->conf.channel->band != IEEE80211_BAND_5GHZ)
                        sc->sc_flags |= SC_OP_PROTECT_ENABLE;
@@ -1930,7 +1974,7 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
        }
 
        if (changed & BSS_CHANGED_ASSOC) {
-               ath_print(common, ATH_DBG_CONFIG, "BSS Changed ASSOC %d\n",
+               ath_dbg(common, ATH_DBG_CONFIG, "BSS Changed ASSOC %d\n",
                        bss_conf->assoc);
                ath9k_bss_assoc_info(sc, hw, vif, bss_conf);
        }
@@ -1945,7 +1989,9 @@ static u64 ath9k_get_tsf(struct ieee80211_hw *hw)
        struct ath_softc *sc = aphy->sc;
 
        mutex_lock(&sc->mutex);
+       ath9k_ps_wakeup(sc);
        tsf = ath9k_hw_gettsf64(sc->sc_ah);
+       ath9k_ps_restore(sc);
        mutex_unlock(&sc->mutex);
 
        return tsf;
@@ -1957,7 +2003,9 @@ static void ath9k_set_tsf(struct ieee80211_hw *hw, u64 tsf)
        struct ath_softc *sc = aphy->sc;
 
        mutex_lock(&sc->mutex);
+       ath9k_ps_wakeup(sc);
        ath9k_hw_settsf64(sc->sc_ah, tsf);
+       ath9k_ps_restore(sc);
        mutex_unlock(&sc->mutex);
 }
 
@@ -2016,8 +2064,7 @@ static int ath9k_ampdu_action(struct ieee80211_hw *hw,
                ath9k_ps_restore(sc);
                break;
        default:
-               ath_print(ath9k_hw_common(sc->sc_ah), ATH_DBG_FATAL,
-                         "Unknown AMPDU action\n");
+               ath_err(ath9k_hw_common(sc->sc_ah), "Unknown AMPDU action\n");
        }
 
        local_bh_enable();
@@ -2117,6 +2164,7 @@ struct ieee80211_ops ath9k_ops = {
        .start              = ath9k_start,
        .stop               = ath9k_stop,
        .add_interface      = ath9k_add_interface,
+       .change_interface   = ath9k_change_interface,
        .remove_interface   = ath9k_remove_interface,
        .config             = ath9k_config,
        .configure_filter   = ath9k_configure_filter,