target: Fix off-by-seven in target_report_luns
authorJörn Engel <joern@logfs.org>
Thu, 16 Feb 2012 16:14:27 +0000 (11:14 -0500)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 25 Feb 2012 22:37:50 +0000 (14:37 -0800)
commit99f730d88fd0a25c3e2dfc357bde4cf6b8cb5b40
tree94b74e3bbceda90501e550543dfc82f0bde13917
parent47f1b8803e1e358ebbf4f82bfdb98971c912a2c3
target: Fix off-by-seven in target_report_luns

cdb_offset is always equal to offset - 8, so remove that one.  More
importantly, the existing code only worked correct if
se_cmd->data_length is a multiple of 8.  Pass in a length of, say, 9 and
we will happily overwrite 7 bytes of "unallocated" memory.

Now, afaics this bug is currently harmless, as allocations will
implicitly be padded to multiples of 8 bytes.  But depending on such a
fact wouldn't qualify as sound engineering practice.

Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_device.c