Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git...
[linux-flexiantxendom0-3.2.10.git] / arch / arm / mach-omap2 / clockdomain.c
index f70b06a..ad07689 100644 (file)
@@ -1,8 +1,8 @@
 /*
  * OMAP2/3/4 clockdomain framework functions
  *
- * Copyright (C) 2008-2010 Texas Instruments, Inc.
- * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyright (C) 2008-2011 Texas Instruments, Inc.
+ * Copyright (C) 2008-2011 Nokia Corporation
  *
  * Written by Paul Walmsley and Jouni Högander
  * Added OMAP4 specific support by Abhijit Pagare <abhijitpagare@ti.com>
@@ -17,6 +17,7 @@
 #include <linux/device.h>
 #include <linux/list.h>
 #include <linux/errno.h>
+#include <linux/string.h>
 #include <linux/delay.h>
 #include <linux/clk.h>
 #include <linux/limits.h>
 
 #include <linux/bitops.h>
 
-#include "prm2xxx_3xxx.h"
-#include "prm-regbits-24xx.h"
-#include "cm2xxx_3xxx.h"
-#include "cm-regbits-24xx.h"
-#include "cminst44xx.h"
-#include "prcm44xx.h"
-
 #include <plat/clock.h>
-#include "powerdomain.h"
 #include "clockdomain.h"
-#include <plat/prcm.h>
 
 /* clkdm_list contains all registered struct clockdomains */
 static LIST_HEAD(clkdm_list);
@@ -82,9 +74,6 @@ static int _clkdm_register(struct clockdomain *clkdm)
        if (!clkdm || !clkdm->name)
                return -EINVAL;
 
-       if (!omap_chip_is(clkdm->omap_chip))
-               return -EINVAL;
-
        pwrdm = pwrdm_lookup(clkdm->pwrdm.name);
        if (!pwrdm) {
                pr_err("clockdomain: %s: powerdomain %s does not exist\n",
@@ -101,6 +90,8 @@ static int _clkdm_register(struct clockdomain *clkdm)
 
        pwrdm_add_clkdm(pwrdm, clkdm);
 
+       spin_lock_init(&clkdm->lock);
+
        pr_debug("clockdomain: registered %s\n", clkdm->name);
 
        return 0;
@@ -112,13 +103,10 @@ static struct clkdm_dep *_clkdm_deps_lookup(struct clockdomain *clkdm,
 {
        struct clkdm_dep *cd;
 
-       if (!clkdm || !deps || !omap_chip_is(clkdm->omap_chip))
+       if (!clkdm || !deps)
                return ERR_PTR(-EINVAL);
 
        for (cd = deps; cd->clkdm_name; cd++) {
-               if (!omap_chip_is(cd->omap_chip))
-                       continue;
-
                if (!cd->clkdm && cd->clkdm_name)
                        cd->clkdm = _clkdm_lookup(cd->clkdm_name);
 
@@ -155,9 +143,6 @@ static void _autodep_lookup(struct clkdm_autodep *autodep)
        if (!autodep)
                return;
 
-       if (!omap_chip_is(autodep->omap_chip))
-               return;
-
        clkdm = clkdm_lookup(autodep->clkdm.name);
        if (!clkdm) {
                pr_err("clockdomain: autodeps: clockdomain %s does not exist\n",
@@ -178,20 +163,17 @@ static void _autodep_lookup(struct clkdm_autodep *autodep)
  * XXX autodeps are deprecated and should be removed at the earliest
  * opportunity
  */
-static void _clkdm_add_autodeps(struct clockdomain *clkdm)
+void _clkdm_add_autodeps(struct clockdomain *clkdm)
 {
        struct clkdm_autodep *autodep;
 
-       if (!autodeps)
+       if (!autodeps || clkdm->flags & CLKDM_NO_AUTODEPS)
                return;
 
        for (autodep = autodeps; autodep->clkdm.ptr; autodep++) {
                if (IS_ERR(autodep->clkdm.ptr))
                        continue;
 
-               if (!omap_chip_is(autodep->omap_chip))
-                       continue;
-
                pr_debug("clockdomain: adding %s sleepdep/wkdep for "
                         "clkdm %s\n", autodep->clkdm.ptr->name,
                         clkdm->name);
@@ -212,20 +194,17 @@ static void _clkdm_add_autodeps(struct clockdomain *clkdm)
  * XXX autodeps are deprecated and should be removed at the earliest
  * opportunity
  */
-static void _clkdm_del_autodeps(struct clockdomain *clkdm)
+void _clkdm_del_autodeps(struct clockdomain *clkdm)
 {
        struct clkdm_autodep *autodep;
 
-       if (!autodeps)
+       if (!autodeps || clkdm->flags & CLKDM_NO_AUTODEPS)
                return;
 
        for (autodep = autodeps; autodep->clkdm.ptr; autodep++) {
                if (IS_ERR(autodep->clkdm.ptr))
                        continue;
 
-               if (!omap_chip_is(autodep->omap_chip))
-                       continue;
-
                pr_debug("clockdomain: removing %s sleepdep/wkdep for "
                         "clkdm %s\n", autodep->clkdm.ptr->name,
                         clkdm->name);
@@ -236,106 +215,153 @@ static void _clkdm_del_autodeps(struct clockdomain *clkdm)
 }
 
 /**
- * _enable_hwsup - place a clockdomain into hardware-supervised idle
- * @clkdm: struct clockdomain *
+ * _resolve_clkdm_deps() - resolve clkdm_names in @clkdm_deps to clkdms
+ * @clkdm: clockdomain that we are resolving dependencies for
+ * @clkdm_deps: ptr to array of struct clkdm_deps to resolve
  *
- * Place the clockdomain into hardware-supervised idle mode.  No return
- * value.
- *
- * XXX Should this return an error if the clockdomain does not support
- * hardware-supervised idle mode?
+ * Iterates through @clkdm_deps, looking up the struct clockdomain named by
+ * clkdm_name and storing the clockdomain pointer in the struct clkdm_dep.
+ * No return value.
  */
-static void _enable_hwsup(struct clockdomain *clkdm)
+static void _resolve_clkdm_deps(struct clockdomain *clkdm,
+                               struct clkdm_dep *clkdm_deps)
 {
-       if (cpu_is_omap24xx())
-               omap2xxx_cm_clkdm_enable_hwsup(clkdm->pwrdm.ptr->prcm_offs,
-                                              clkdm->clktrctrl_mask);
-       else if (cpu_is_omap34xx())
-               omap3xxx_cm_clkdm_enable_hwsup(clkdm->pwrdm.ptr->prcm_offs,
-                                              clkdm->clktrctrl_mask);
-       else if (cpu_is_omap44xx())
-               return omap4_cminst_clkdm_enable_hwsup(clkdm->prcm_partition,
-                                                      clkdm->cm_inst,
-                                                      clkdm->clkdm_offs);
-       else
-               BUG();
+       struct clkdm_dep *cd;
+
+       for (cd = clkdm_deps; cd && cd->clkdm_name; cd++) {
+               if (cd->clkdm)
+                       continue;
+               cd->clkdm = _clkdm_lookup(cd->clkdm_name);
+
+               WARN(!cd->clkdm, "clockdomain: %s: could not find clkdm %s while resolving dependencies - should never happen",
+                    clkdm->name, cd->clkdm_name);
+       }
 }
 
+/* Public functions */
+
 /**
- * _disable_hwsup - place a clockdomain into software-supervised idle
- * @clkdm: struct clockdomain *
- *
- * Place the clockdomain @clkdm into software-supervised idle mode.
- * No return value.
+ * clkdm_register_platform_funcs - register clockdomain implementation fns
+ * @co: func pointers for arch specific implementations
  *
- * XXX Should this return an error if the clockdomain does not support
- * software-supervised idle mode?
+ * Register the list of function pointers used to implement the
+ * clockdomain functions on different OMAP SoCs.  Should be called
+ * before any other clkdm_register*() function.  Returns -EINVAL if
+ * @co is null, -EEXIST if platform functions have already been
+ * registered, or 0 upon success.
  */
-static void _disable_hwsup(struct clockdomain *clkdm)
+int clkdm_register_platform_funcs(struct clkdm_ops *co)
 {
-       if (cpu_is_omap24xx())
-               omap2xxx_cm_clkdm_disable_hwsup(clkdm->pwrdm.ptr->prcm_offs,
-                                               clkdm->clktrctrl_mask);
-       else if (cpu_is_omap34xx())
-               omap3xxx_cm_clkdm_disable_hwsup(clkdm->pwrdm.ptr->prcm_offs,
-                                               clkdm->clktrctrl_mask);
-       else if (cpu_is_omap44xx())
-               return omap4_cminst_clkdm_disable_hwsup(clkdm->prcm_partition,
-                                                       clkdm->cm_inst,
-                                                       clkdm->clkdm_offs);
-       else
-               BUG();
-}
+       if (!co)
+               return -EINVAL;
 
-/* Public functions */
+       if (arch_clkdm)
+               return -EEXIST;
+
+       arch_clkdm = co;
+
+       return 0;
+};
 
 /**
- * clkdm_init - set up the clockdomain layer
- * @clkdms: optional pointer to an array of clockdomains to register
- * @init_autodeps: optional pointer to an array of autodeps to register
- * @custom_funcs: func pointers for arch specfic implementations
+ * clkdm_register_clkdms - register SoC clockdomains
+ * @cs: pointer to an array of struct clockdomain to register
  *
- * Set up internal state.  If a pointer to an array of clockdomains
- * @clkdms was supplied, loop through the list of clockdomains,
- * register all that are available on the current platform. Similarly,
- * if a pointer to an array of clockdomain autodependencies
- * @init_autodeps was provided, register those.  No return value.
+ * Register the clockdomains available on a particular OMAP SoC.  Must
+ * be called after clkdm_register_platform_funcs().  May be called
+ * multiple times.  Returns -EACCES if called before
+ * clkdm_register_platform_funcs(); -EINVAL if the argument @cs is
+ * null; or 0 upon success.
  */
-void clkdm_init(struct clockdomain **clkdms,
-               struct clkdm_autodep *init_autodeps,
-               struct clkdm_ops *custom_funcs)
+int clkdm_register_clkdms(struct clockdomain **cs)
 {
        struct clockdomain **c = NULL;
-       struct clockdomain *clkdm;
-       struct clkdm_autodep *autodep = NULL;
 
-       if (!custom_funcs)
-               WARN(1, "No custom clkdm functions registered\n");
-       else
-               arch_clkdm = custom_funcs;
+       if (!arch_clkdm)
+               return -EACCES;
 
-       if (clkdms)
-               for (c = clkdms; *c; c++)
-                       _clkdm_register(*c);
+       if (!cs)
+               return -EINVAL;
+
+       for (c = cs; *c; c++)
+               _clkdm_register(*c);
+
+       return 0;
+}
+
+/**
+ * clkdm_register_autodeps - register autodeps (if required)
+ * @ia: pointer to a static array of struct clkdm_autodep to register
+ *
+ * Register clockdomain "automatic dependencies."  These are
+ * clockdomain wakeup and sleep dependencies that are automatically
+ * added whenever the first clock inside a clockdomain is enabled, and
+ * removed whenever the last clock inside a clockdomain is disabled.
+ * These are currently only used on OMAP3 devices, and are deprecated,
+ * since they waste energy.  However, until the OMAP2/3 IP block
+ * enable/disable sequence can be converted to match the OMAP4
+ * sequence, they are needed.
+ *
+ * Must be called only after all of the SoC clockdomains are
+ * registered, since the function will resolve autodep clockdomain
+ * names into clockdomain pointers.
+ *
+ * The struct clkdm_autodep @ia array must be static, as this function
+ * does not copy the array elements.
+ *
+ * Returns -EACCES if called before any clockdomains have been
+ * registered, -EINVAL if called with a null @ia argument, -EEXIST if
+ * autodeps have already been registered, or 0 upon success.
+ */
+int clkdm_register_autodeps(struct clkdm_autodep *ia)
+{
+       struct clkdm_autodep *a = NULL;
+
+       if (list_empty(&clkdm_list))
+               return -EACCES;
+
+       if (!ia)
+               return -EINVAL;
 
-       autodeps = init_autodeps;
        if (autodeps)
-               for (autodep = autodeps; autodep->clkdm.ptr; autodep++)
-                       _autodep_lookup(autodep);
+               return -EEXIST;
+
+       autodeps = ia;
+       for (a = autodeps; a->clkdm.ptr; a++)
+               _autodep_lookup(a);
+
+       return 0;
+}
+
+/**
+ * clkdm_complete_init - set up the clockdomain layer
+ *
+ * Put all clockdomains into software-supervised mode; PM code should
+ * later enable hardware-supervised mode as appropriate.  Must be
+ * called after clkdm_register_clkdms().  Returns -EACCES if called
+ * before clkdm_register_clkdms(), or 0 upon success.
+ */
+int clkdm_complete_init(void)
+{
+       struct clockdomain *clkdm;
+
+       if (list_empty(&clkdm_list))
+               return -EACCES;
 
-       /*
-        * Put all clockdomains into software-supervised mode; PM code
-        * should later enable hardware-supervised mode as appropriate
-        */
        list_for_each_entry(clkdm, &clkdm_list, node) {
                if (clkdm->flags & CLKDM_CAN_FORCE_WAKEUP)
-                       omap2_clkdm_wakeup(clkdm);
+                       clkdm_wakeup(clkdm);
                else if (clkdm->flags & CLKDM_CAN_DISABLE_AUTO)
-                       omap2_clkdm_deny_idle(clkdm);
+                       clkdm_deny_idle(clkdm);
 
+               _resolve_clkdm_deps(clkdm, clkdm->wkdep_srcs);
                clkdm_clear_all_wkdeps(clkdm);
+
+               _resolve_clkdm_deps(clkdm, clkdm->sleepdep_srcs);
                clkdm_clear_all_sleepdeps(clkdm);
        }
+
+       return 0;
 }
 
 /**
@@ -430,32 +456,32 @@ struct powerdomain *clkdm_get_pwrdm(struct clockdomain *clkdm)
 int clkdm_add_wkdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 {
        struct clkdm_dep *cd;
-
-       if (!cpu_is_omap24xx() && !cpu_is_omap34xx()) {
-               pr_err("clockdomain: %s/%s: %s: not yet implemented\n",
-                      clkdm1->name, clkdm2->name, __func__);
-               return -EINVAL;
-       }
+       int ret = 0;
 
        if (!clkdm1 || !clkdm2)
                return -EINVAL;
 
        cd = _clkdm_deps_lookup(clkdm2, clkdm1->wkdep_srcs);
-       if (IS_ERR(cd)) {
+       if (IS_ERR(cd))
+               ret = PTR_ERR(cd);
+
+       if (!arch_clkdm || !arch_clkdm->clkdm_add_wkdep)
+               ret = -EINVAL;
+
+       if (ret) {
                pr_debug("clockdomain: hardware cannot set/clear wake up of "
                         "%s when %s wakes up\n", clkdm1->name, clkdm2->name);
-               return PTR_ERR(cd);
+               return ret;
        }
 
        if (atomic_inc_return(&cd->wkdep_usecount) == 1) {
                pr_debug("clockdomain: hardware will wake up %s when %s wakes "
                         "up\n", clkdm1->name, clkdm2->name);
 
-               omap2_prm_set_mod_reg_bits((1 << clkdm2->dep_bit),
-                                    clkdm1->pwrdm.ptr->prcm_offs, PM_WKDEP);
+               ret = arch_clkdm->clkdm_add_wkdep(clkdm1, clkdm2);
        }
 
-       return 0;
+       return ret;
 }
 
 /**
@@ -471,32 +497,32 @@ int clkdm_add_wkdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 int clkdm_del_wkdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 {
        struct clkdm_dep *cd;
-
-       if (!cpu_is_omap24xx() && !cpu_is_omap34xx()) {
-               pr_err("clockdomain: %s/%s: %s: not yet implemented\n",
-                      clkdm1->name, clkdm2->name, __func__);
-               return -EINVAL;
-       }
+       int ret = 0;
 
        if (!clkdm1 || !clkdm2)
                return -EINVAL;
 
        cd = _clkdm_deps_lookup(clkdm2, clkdm1->wkdep_srcs);
-       if (IS_ERR(cd)) {
+       if (IS_ERR(cd))
+               ret = PTR_ERR(cd);
+
+       if (!arch_clkdm || !arch_clkdm->clkdm_del_wkdep)
+               ret = -EINVAL;
+
+       if (ret) {
                pr_debug("clockdomain: hardware cannot set/clear wake up of "
                         "%s when %s wakes up\n", clkdm1->name, clkdm2->name);
-               return PTR_ERR(cd);
+               return ret;
        }
 
        if (atomic_dec_return(&cd->wkdep_usecount) == 0) {
                pr_debug("clockdomain: hardware will no longer wake up %s "
                         "after %s wakes up\n", clkdm1->name, clkdm2->name);
 
-               omap2_prm_clear_mod_reg_bits((1 << clkdm2->dep_bit),
-                                      clkdm1->pwrdm.ptr->prcm_offs, PM_WKDEP);
+               ret = arch_clkdm->clkdm_del_wkdep(clkdm1, clkdm2);
        }
 
-       return 0;
+       return ret;
 }
 
 /**
@@ -516,26 +542,26 @@ int clkdm_del_wkdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 int clkdm_read_wkdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 {
        struct clkdm_dep *cd;
+       int ret = 0;
 
        if (!clkdm1 || !clkdm2)
                return -EINVAL;
 
-       if (!cpu_is_omap24xx() && !cpu_is_omap34xx()) {
-               pr_err("clockdomain: %s/%s: %s: not yet implemented\n",
-                      clkdm1->name, clkdm2->name, __func__);
-               return -EINVAL;
-       }
-
        cd = _clkdm_deps_lookup(clkdm2, clkdm1->wkdep_srcs);
-       if (IS_ERR(cd)) {
+       if (IS_ERR(cd))
+               ret = PTR_ERR(cd);
+
+       if (!arch_clkdm || !arch_clkdm->clkdm_read_wkdep)
+               ret = -EINVAL;
+
+       if (ret) {
                pr_debug("clockdomain: hardware cannot set/clear wake up of "
                         "%s when %s wakes up\n", clkdm1->name, clkdm2->name);
-               return PTR_ERR(cd);
+               return ret;
        }
 
        /* XXX It's faster to return the atomic wkdep_usecount */
-       return omap2_prm_read_mod_bits_shift(clkdm1->pwrdm.ptr->prcm_offs, PM_WKDEP,
-                                      (1 << clkdm2->dep_bit));
+       return arch_clkdm->clkdm_read_wkdep(clkdm1, clkdm2);
 }
 
 /**
@@ -550,33 +576,13 @@ int clkdm_read_wkdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
  */
 int clkdm_clear_all_wkdeps(struct clockdomain *clkdm)
 {
-       struct clkdm_dep *cd;
-       u32 mask = 0;
-
-       if (!cpu_is_omap24xx() && !cpu_is_omap34xx()) {
-               pr_err("clockdomain: %s: %s: not yet implemented\n",
-                      clkdm->name, __func__);
-               return -EINVAL;
-       }
-
        if (!clkdm)
                return -EINVAL;
 
-       for (cd = clkdm->wkdep_srcs; cd && cd->clkdm_name; cd++) {
-               if (!omap_chip_is(cd->omap_chip))
-                       continue;
-
-               if (!cd->clkdm && cd->clkdm_name)
-                       cd->clkdm = _clkdm_lookup(cd->clkdm_name);
-
-               /* PRM accesses are slow, so minimize them */
-               mask |= 1 << cd->clkdm->dep_bit;
-               atomic_set(&cd->wkdep_usecount, 0);
-       }
-
-       omap2_prm_clear_mod_reg_bits(mask, clkdm->pwrdm.ptr->prcm_offs, PM_WKDEP);
+       if (!arch_clkdm || !arch_clkdm->clkdm_clear_all_wkdeps)
+               return -EINVAL;
 
-       return 0;
+       return arch_clkdm->clkdm_clear_all_wkdeps(clkdm);
 }
 
 /**
@@ -594,31 +600,33 @@ int clkdm_clear_all_wkdeps(struct clockdomain *clkdm)
 int clkdm_add_sleepdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 {
        struct clkdm_dep *cd;
-
-       if (!cpu_is_omap34xx())
-               return -EINVAL;
+       int ret = 0;
 
        if (!clkdm1 || !clkdm2)
                return -EINVAL;
 
        cd = _clkdm_deps_lookup(clkdm2, clkdm1->sleepdep_srcs);
-       if (IS_ERR(cd)) {
+       if (IS_ERR(cd))
+               ret = PTR_ERR(cd);
+
+       if (!arch_clkdm || !arch_clkdm->clkdm_add_sleepdep)
+               ret = -EINVAL;
+
+       if (ret) {
                pr_debug("clockdomain: hardware cannot set/clear sleep "
                         "dependency affecting %s from %s\n", clkdm1->name,
                         clkdm2->name);
-               return PTR_ERR(cd);
+               return ret;
        }
 
        if (atomic_inc_return(&cd->sleepdep_usecount) == 1) {
                pr_debug("clockdomain: will prevent %s from sleeping if %s "
                         "is active\n", clkdm1->name, clkdm2->name);
 
-               omap2_cm_set_mod_reg_bits((1 << clkdm2->dep_bit),
-                                   clkdm1->pwrdm.ptr->prcm_offs,
-                                   OMAP3430_CM_SLEEPDEP);
+               ret = arch_clkdm->clkdm_add_sleepdep(clkdm1, clkdm2);
        }
 
-       return 0;
+       return ret;
 }
 
 /**
@@ -636,19 +644,23 @@ int clkdm_add_sleepdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 int clkdm_del_sleepdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 {
        struct clkdm_dep *cd;
-
-       if (!cpu_is_omap34xx())
-               return -EINVAL;
+       int ret = 0;
 
        if (!clkdm1 || !clkdm2)
                return -EINVAL;
 
        cd = _clkdm_deps_lookup(clkdm2, clkdm1->sleepdep_srcs);
-       if (IS_ERR(cd)) {
+       if (IS_ERR(cd))
+               ret = PTR_ERR(cd);
+
+       if (!arch_clkdm || !arch_clkdm->clkdm_del_sleepdep)
+               ret = -EINVAL;
+
+       if (ret) {
                pr_debug("clockdomain: hardware cannot set/clear sleep "
                         "dependency affecting %s from %s\n", clkdm1->name,
                         clkdm2->name);
-               return PTR_ERR(cd);
+               return ret;
        }
 
        if (atomic_dec_return(&cd->sleepdep_usecount) == 0) {
@@ -656,12 +668,10 @@ int clkdm_del_sleepdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
                         "sleeping if %s is active\n", clkdm1->name,
                         clkdm2->name);
 
-               omap2_cm_clear_mod_reg_bits((1 << clkdm2->dep_bit),
-                                     clkdm1->pwrdm.ptr->prcm_offs,
-                                     OMAP3430_CM_SLEEPDEP);
+               ret = arch_clkdm->clkdm_del_sleepdep(clkdm1, clkdm2);
        }
 
-       return 0;
+       return ret;
 }
 
 /**
@@ -683,25 +693,27 @@ int clkdm_del_sleepdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 int clkdm_read_sleepdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
 {
        struct clkdm_dep *cd;
-
-       if (!cpu_is_omap34xx())
-               return -EINVAL;
+       int ret = 0;
 
        if (!clkdm1 || !clkdm2)
                return -EINVAL;
 
        cd = _clkdm_deps_lookup(clkdm2, clkdm1->sleepdep_srcs);
-       if (IS_ERR(cd)) {
+       if (IS_ERR(cd))
+               ret = PTR_ERR(cd);
+
+       if (!arch_clkdm || !arch_clkdm->clkdm_read_sleepdep)
+               ret = -EINVAL;
+
+       if (ret) {
                pr_debug("clockdomain: hardware cannot set/clear sleep "
                         "dependency affecting %s from %s\n", clkdm1->name,
                         clkdm2->name);
-               return PTR_ERR(cd);
+               return ret;
        }
 
        /* XXX It's faster to return the atomic sleepdep_usecount */
-       return omap2_prm_read_mod_bits_shift(clkdm1->pwrdm.ptr->prcm_offs,
-                                      OMAP3430_CM_SLEEPDEP,
-                                      (1 << clkdm2->dep_bit));
+       return arch_clkdm->clkdm_read_sleepdep(clkdm1, clkdm2);
 }
 
 /**
@@ -716,35 +728,17 @@ int clkdm_read_sleepdep(struct clockdomain *clkdm1, struct clockdomain *clkdm2)
  */
 int clkdm_clear_all_sleepdeps(struct clockdomain *clkdm)
 {
-       struct clkdm_dep *cd;
-       u32 mask = 0;
-
-       if (!cpu_is_omap34xx())
-               return -EINVAL;
-
        if (!clkdm)
                return -EINVAL;
 
-       for (cd = clkdm->sleepdep_srcs; cd && cd->clkdm_name; cd++) {
-               if (!omap_chip_is(cd->omap_chip))
-                       continue;
-
-               if (!cd->clkdm && cd->clkdm_name)
-                       cd->clkdm = _clkdm_lookup(cd->clkdm_name);
-
-               /* PRM accesses are slow, so minimize them */
-               mask |= 1 << cd->clkdm->dep_bit;
-               atomic_set(&cd->sleepdep_usecount, 0);
-       }
-
-       omap2_prm_clear_mod_reg_bits(mask, clkdm->pwrdm.ptr->prcm_offs,
-                              OMAP3430_CM_SLEEPDEP);
+       if (!arch_clkdm || !arch_clkdm->clkdm_clear_all_sleepdeps)
+               return -EINVAL;
 
-       return 0;
+       return arch_clkdm->clkdm_clear_all_sleepdeps(clkdm);
 }
 
 /**
- * omap2_clkdm_sleep - force clockdomain sleep transition
+ * clkdm_sleep - force clockdomain sleep transition
  * @clkdm: struct clockdomain *
  *
  * Instruct the CM to force a sleep transition on the specified
@@ -752,8 +746,11 @@ int clkdm_clear_all_sleepdeps(struct clockdomain *clkdm)
  * clockdomain does not support software-initiated sleep; 0 upon
  * success.
  */
-int omap2_clkdm_sleep(struct clockdomain *clkdm)
+int clkdm_sleep(struct clockdomain *clkdm)
 {
+       int ret;
+       unsigned long flags;
+
        if (!clkdm)
                return -EINVAL;
 
@@ -763,33 +760,20 @@ int omap2_clkdm_sleep(struct clockdomain *clkdm)
                return -EINVAL;
        }
 
-       pr_debug("clockdomain: forcing sleep on %s\n", clkdm->name);
-
-       if (cpu_is_omap24xx()) {
-
-               omap2_cm_set_mod_reg_bits(OMAP24XX_FORCESTATE_MASK,
-                           clkdm->pwrdm.ptr->prcm_offs, OMAP2_PM_PWSTCTRL);
-
-       } else if (cpu_is_omap34xx()) {
-
-               omap3xxx_cm_clkdm_force_sleep(clkdm->pwrdm.ptr->prcm_offs,
-                                             clkdm->clktrctrl_mask);
-
-       } else if (cpu_is_omap44xx()) {
-
-               omap4_cminst_clkdm_force_sleep(clkdm->prcm_partition,
-                                              clkdm->cm_inst,
-                                              clkdm->clkdm_offs);
+       if (!arch_clkdm || !arch_clkdm->clkdm_sleep)
+               return -EINVAL;
 
-       } else {
-               BUG();
-       };
+       pr_debug("clockdomain: forcing sleep on %s\n", clkdm->name);
 
-       return 0;
+       spin_lock_irqsave(&clkdm->lock, flags);
+       clkdm->_flags &= ~_CLKDM_FLAG_HWSUP_ENABLED;
+       ret = arch_clkdm->clkdm_sleep(clkdm);
+       spin_unlock_irqrestore(&clkdm->lock, flags);
+       return ret;
 }
 
 /**
- * omap2_clkdm_wakeup - force clockdomain wakeup transition
+ * clkdm_wakeup - force clockdomain wakeup transition
  * @clkdm: struct clockdomain *
  *
  * Instruct the CM to force a wakeup transition on the specified
@@ -797,8 +781,11 @@ int omap2_clkdm_sleep(struct clockdomain *clkdm)
  * clockdomain does not support software-controlled wakeup; 0 upon
  * success.
  */
-int omap2_clkdm_wakeup(struct clockdomain *clkdm)
+int clkdm_wakeup(struct clockdomain *clkdm)
 {
+       int ret;
+       unsigned long flags;
+
        if (!clkdm)
                return -EINVAL;
 
@@ -808,33 +795,21 @@ int omap2_clkdm_wakeup(struct clockdomain *clkdm)
                return -EINVAL;
        }
 
-       pr_debug("clockdomain: forcing wakeup on %s\n", clkdm->name);
-
-       if (cpu_is_omap24xx()) {
-
-               omap2_cm_clear_mod_reg_bits(OMAP24XX_FORCESTATE_MASK,
-                             clkdm->pwrdm.ptr->prcm_offs, OMAP2_PM_PWSTCTRL);
-
-       } else if (cpu_is_omap34xx()) {
-
-               omap3xxx_cm_clkdm_force_wakeup(clkdm->pwrdm.ptr->prcm_offs,
-                                              clkdm->clktrctrl_mask);
-
-       } else if (cpu_is_omap44xx()) {
-
-               omap4_cminst_clkdm_force_wakeup(clkdm->prcm_partition,
-                                               clkdm->cm_inst,
-                                               clkdm->clkdm_offs);
+       if (!arch_clkdm || !arch_clkdm->clkdm_wakeup)
+               return -EINVAL;
 
-       } else {
-               BUG();
-       };
+       pr_debug("clockdomain: forcing wakeup on %s\n", clkdm->name);
 
-       return 0;
+       spin_lock_irqsave(&clkdm->lock, flags);
+       clkdm->_flags &= ~_CLKDM_FLAG_HWSUP_ENABLED;
+       ret = arch_clkdm->clkdm_wakeup(clkdm);
+       ret |= pwrdm_state_switch(clkdm->pwrdm.ptr);
+       spin_unlock_irqrestore(&clkdm->lock, flags);
+       return ret;
 }
 
 /**
- * omap2_clkdm_allow_idle - enable hwsup idle transitions for clkdm
+ * clkdm_allow_idle - enable hwsup idle transitions for clkdm
  * @clkdm: struct clockdomain *
  *
  * Allow the hardware to automatically switch the clockdomain @clkdm into
@@ -843,8 +818,10 @@ int omap2_clkdm_wakeup(struct clockdomain *clkdm)
  * framework, wkdep/sleepdep autodependencies are added; this is so
  * device drivers can read and write to the device.  No return value.
  */
-void omap2_clkdm_allow_idle(struct clockdomain *clkdm)
+void clkdm_allow_idle(struct clockdomain *clkdm)
 {
+       unsigned long flags;
+
        if (!clkdm)
                return;
 
@@ -854,27 +831,21 @@ void omap2_clkdm_allow_idle(struct clockdomain *clkdm)
                return;
        }
 
+       if (!arch_clkdm || !arch_clkdm->clkdm_allow_idle)
+               return;
+
        pr_debug("clockdomain: enabling automatic idle transitions for %s\n",
                 clkdm->name);
 
-       /*
-        * XXX This should be removed once TI adds wakeup/sleep
-        * dependency code and data for OMAP4.
-        */
-       if (cpu_is_omap44xx()) {
-               pr_err("clockdomain: %s: OMAP4 wakeup/sleep dependency support: not yet implemented\n", clkdm->name);
-       } else {
-               if (atomic_read(&clkdm->usecount) > 0)
-                       _clkdm_add_autodeps(clkdm);
-       }
-
-       _enable_hwsup(clkdm);
-
+       spin_lock_irqsave(&clkdm->lock, flags);
+       clkdm->_flags |= _CLKDM_FLAG_HWSUP_ENABLED;
+       arch_clkdm->clkdm_allow_idle(clkdm);
        pwrdm_clkdm_state_switch(clkdm);
+       spin_unlock_irqrestore(&clkdm->lock, flags);
 }
 
 /**
- * omap2_clkdm_deny_idle - disable hwsup idle transitions for clkdm
+ * clkdm_deny_idle - disable hwsup idle transitions for clkdm
  * @clkdm: struct clockdomain *
  *
  * Prevent the hardware from automatically switching the clockdomain
@@ -882,8 +853,10 @@ void omap2_clkdm_allow_idle(struct clockdomain *clkdm)
  * downstream clocks enabled in the clock framework, wkdep/sleepdep
  * autodependencies are removed.  No return value.
  */
-void omap2_clkdm_deny_idle(struct clockdomain *clkdm)
+void clkdm_deny_idle(struct clockdomain *clkdm)
 {
+       unsigned long flags;
+
        if (!clkdm)
                return;
 
@@ -893,28 +866,100 @@ void omap2_clkdm_deny_idle(struct clockdomain *clkdm)
                return;
        }
 
+       if (!arch_clkdm || !arch_clkdm->clkdm_deny_idle)
+               return;
+
        pr_debug("clockdomain: disabling automatic idle transitions for %s\n",
                 clkdm->name);
 
-       _disable_hwsup(clkdm);
+       spin_lock_irqsave(&clkdm->lock, flags);
+       clkdm->_flags &= ~_CLKDM_FLAG_HWSUP_ENABLED;
+       arch_clkdm->clkdm_deny_idle(clkdm);
+       pwrdm_state_switch(clkdm->pwrdm.ptr);
+       spin_unlock_irqrestore(&clkdm->lock, flags);
+}
+
+/**
+ * clkdm_in_hwsup - is clockdomain @clkdm have hardware-supervised idle enabled?
+ * @clkdm: struct clockdomain *
+ *
+ * Returns true if clockdomain @clkdm currently has
+ * hardware-supervised idle enabled, or false if it does not or if
+ * @clkdm is NULL.  It is only valid to call this function after
+ * clkdm_init() has been called.  This function does not actually read
+ * bits from the hardware; it instead tests an in-memory flag that is
+ * changed whenever the clockdomain code changes the auto-idle mode.
+ */
+bool clkdm_in_hwsup(struct clockdomain *clkdm)
+{
+       bool ret;
+       unsigned long flags;
+
+       if (!clkdm)
+               return false;
+
+       spin_lock_irqsave(&clkdm->lock, flags);
+       ret = (clkdm->_flags & _CLKDM_FLAG_HWSUP_ENABLED) ? true : false;
+       spin_unlock_irqrestore(&clkdm->lock, flags);
+
+       return ret;
+}
+
+/* Clockdomain-to-clock/hwmod framework interface code */
+
+static int _clkdm_clk_hwmod_enable(struct clockdomain *clkdm)
+{
+       unsigned long flags;
+
+       if (!clkdm || !arch_clkdm || !arch_clkdm->clkdm_clk_enable)
+               return -EINVAL;
 
        /*
-        * XXX This should be removed once TI adds wakeup/sleep
-        * dependency code and data for OMAP4.
+        * For arch's with no autodeps, clkcm_clk_enable
+        * should be called for every clock instance or hwmod that is
+        * enabled, so the clkdm can be force woken up.
         */
-       if (cpu_is_omap44xx()) {
-               pr_err("clockdomain: %s: OMAP4 wakeup/sleep dependency support: not yet implemented\n", clkdm->name);
-       } else {
-               if (atomic_read(&clkdm->usecount) > 0)
-                       _clkdm_del_autodeps(clkdm);
-       }
+       if ((atomic_inc_return(&clkdm->usecount) > 1) && autodeps)
+               return 0;
+
+       spin_lock_irqsave(&clkdm->lock, flags);
+       arch_clkdm->clkdm_clk_enable(clkdm);
+       pwrdm_wait_transition(clkdm->pwrdm.ptr);
+       pwrdm_clkdm_state_switch(clkdm);
+       spin_unlock_irqrestore(&clkdm->lock, flags);
+
+       pr_debug("clockdomain: clkdm %s: enabled\n", clkdm->name);
+
+       return 0;
 }
 
+static int _clkdm_clk_hwmod_disable(struct clockdomain *clkdm)
+{
+       unsigned long flags;
 
-/* Clockdomain-to-clock framework interface code */
+       if (!clkdm || !arch_clkdm || !arch_clkdm->clkdm_clk_disable)
+               return -EINVAL;
+
+       if (atomic_read(&clkdm->usecount) == 0) {
+               WARN_ON(1); /* underflow */
+               return -ERANGE;
+       }
+
+       if (atomic_dec_return(&clkdm->usecount) > 0)
+               return 0;
+
+       spin_lock_irqsave(&clkdm->lock, flags);
+       arch_clkdm->clkdm_clk_disable(clkdm);
+       pwrdm_clkdm_state_switch(clkdm);
+       spin_unlock_irqrestore(&clkdm->lock, flags);
+
+       pr_debug("clockdomain: clkdm %s: disabled\n", clkdm->name);
+
+       return 0;
+}
 
 /**
- * omap2_clkdm_clk_enable - add an enabled downstream clock to this clkdm
+ * clkdm_clk_enable - add an enabled downstream clock to this clkdm
  * @clkdm: struct clockdomain *
  * @clk: struct clk * of the enabled downstream clock
  *
@@ -927,59 +972,21 @@ void omap2_clkdm_deny_idle(struct clockdomain *clkdm)
  * by on-chip processors.  Returns -EINVAL if passed null pointers;
  * returns 0 upon success or if the clockdomain is in hwsup idle mode.
  */
-int omap2_clkdm_clk_enable(struct clockdomain *clkdm, struct clk *clk)
+int clkdm_clk_enable(struct clockdomain *clkdm, struct clk *clk)
 {
-       bool hwsup = false;
-
        /*
         * XXX Rewrite this code to maintain a list of enabled
         * downstream clocks for debugging purposes?
         */
 
-       if (!clkdm || !clk)
+       if (!clk)
                return -EINVAL;
 
-       if (atomic_inc_return(&clkdm->usecount) > 1)
-               return 0;
-
-       /* Clockdomain now has one enabled downstream clock */
-
-       pr_debug("clockdomain: clkdm %s: clk %s now enabled\n", clkdm->name,
-                clk->name);
-
-       if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
-
-               if (!clkdm->clktrctrl_mask)
-                       return 0;
-
-               hwsup = omap2_cm_is_clkdm_in_hwsup(clkdm->pwrdm.ptr->prcm_offs,
-                                                  clkdm->clktrctrl_mask);
-
-       } else if (cpu_is_omap44xx()) {
-
-               hwsup = omap4_cminst_is_clkdm_in_hwsup(clkdm->prcm_partition,
-                                                      clkdm->cm_inst,
-                                                      clkdm->clkdm_offs);
-
-       }
-
-       if (hwsup) {
-               /* Disable HW transitions when we are changing deps */
-               _disable_hwsup(clkdm);
-               _clkdm_add_autodeps(clkdm);
-               _enable_hwsup(clkdm);
-       } else {
-               omap2_clkdm_wakeup(clkdm);
-       }
-
-       pwrdm_wait_transition(clkdm->pwrdm.ptr);
-       pwrdm_clkdm_state_switch(clkdm);
-
-       return 0;
+       return _clkdm_clk_hwmod_enable(clkdm);
 }
 
 /**
- * omap2_clkdm_clk_disable - remove an enabled downstream clock from this clkdm
+ * clkdm_clk_disable - remove an enabled downstream clock from this clkdm
  * @clkdm: struct clockdomain *
  * @clk: struct clk * of the disabled downstream clock
  *
@@ -988,64 +995,82 @@ int omap2_clkdm_clk_enable(struct clockdomain *clkdm, struct clk *clk)
  * clockdomain usecount goes to 0, put the clockdomain to sleep
  * (software-supervised mode) or remove the clkdm autodependencies
  * (hardware-supervised mode).  Returns -EINVAL if passed null
- * pointers; -ERANGE if the @clkdm usecount underflows and debugging
- * is enabled; or returns 0 upon success or if the clockdomain is in
- * hwsup idle mode.
+ * pointers; -ERANGE if the @clkdm usecount underflows; or returns 0
+ * upon success or if the clockdomain is in hwsup idle mode.
  */
-int omap2_clkdm_clk_disable(struct clockdomain *clkdm, struct clk *clk)
+int clkdm_clk_disable(struct clockdomain *clkdm, struct clk *clk)
 {
-       bool hwsup = false;
-
        /*
         * XXX Rewrite this code to maintain a list of enabled
         * downstream clocks for debugging purposes?
         */
 
-       if (!clkdm || !clk)
+       if (!clk)
                return -EINVAL;
 
-#ifdef DEBUG
-       if (atomic_read(&clkdm->usecount) == 0) {
-               WARN_ON(1); /* underflow */
-               return -ERANGE;
-       }
-#endif
+       return _clkdm_clk_hwmod_disable(clkdm);
+}
 
-       if (atomic_dec_return(&clkdm->usecount) > 0)
+/**
+ * clkdm_hwmod_enable - add an enabled downstream hwmod to this clkdm
+ * @clkdm: struct clockdomain *
+ * @oh: struct omap_hwmod * of the enabled downstream hwmod
+ *
+ * Increment the usecount of the clockdomain @clkdm and ensure that it
+ * is awake before @oh is enabled. Intended to be called by
+ * module_enable() code.
+ * If the clockdomain is in software-supervised idle mode, force the
+ * clockdomain to wake.  If the clockdomain is in hardware-supervised idle
+ * mode, add clkdm-pwrdm autodependencies, to ensure that devices in the
+ * clockdomain can be read from/written to by on-chip processors.
+ * Returns -EINVAL if passed null pointers;
+ * returns 0 upon success or if the clockdomain is in hwsup idle mode.
+ */
+int clkdm_hwmod_enable(struct clockdomain *clkdm, struct omap_hwmod *oh)
+{
+       /* The clkdm attribute does not exist yet prior OMAP4 */
+       if (cpu_is_omap24xx() || cpu_is_omap34xx())
                return 0;
 
-       /* All downstream clocks of this clockdomain are now disabled */
-
-       pr_debug("clockdomain: clkdm %s: clk %s now disabled\n", clkdm->name,
-                clk->name);
-
-       if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
-
-               if (!clkdm->clktrctrl_mask)
-                       return 0;
-
-               hwsup = omap2_cm_is_clkdm_in_hwsup(clkdm->pwrdm.ptr->prcm_offs,
-                                                  clkdm->clktrctrl_mask);
+       /*
+        * XXX Rewrite this code to maintain a list of enabled
+        * downstream hwmods for debugging purposes?
+        */
 
-       } else if (cpu_is_omap44xx()) {
+       if (!oh)
+               return -EINVAL;
 
-               hwsup = omap4_cminst_is_clkdm_in_hwsup(clkdm->prcm_partition,
-                                                      clkdm->cm_inst,
-                                                      clkdm->clkdm_offs);
+       return _clkdm_clk_hwmod_enable(clkdm);
+}
 
-       }
+/**
+ * clkdm_hwmod_disable - remove an enabled downstream hwmod from this clkdm
+ * @clkdm: struct clockdomain *
+ * @oh: struct omap_hwmod * of the disabled downstream hwmod
+ *
+ * Decrement the usecount of this clockdomain @clkdm when @oh is
+ * disabled. Intended to be called by module_disable() code.
+ * If the clockdomain usecount goes to 0, put the clockdomain to sleep
+ * (software-supervised mode) or remove the clkdm autodependencies
+ * (hardware-supervised mode).
+ * Returns -EINVAL if passed null pointers; -ERANGE if the @clkdm usecount
+ * underflows; or returns 0 upon success or if the clockdomain is in hwsup
+ * idle mode.
+ */
+int clkdm_hwmod_disable(struct clockdomain *clkdm, struct omap_hwmod *oh)
+{
+       /* The clkdm attribute does not exist yet prior OMAP4 */
+       if (cpu_is_omap24xx() || cpu_is_omap34xx())
+               return 0;
 
-       if (hwsup) {
-               /* Disable HW transitions when we are changing deps */
-               _disable_hwsup(clkdm);
-               _clkdm_del_autodeps(clkdm);
-               _enable_hwsup(clkdm);
-       } else {
-               omap2_clkdm_sleep(clkdm);
-       }
+       /*
+        * XXX Rewrite this code to maintain a list of enabled
+        * downstream hwmods for debugging purposes?
+        */
 
-       pwrdm_clkdm_state_switch(clkdm);
+       if (!oh)
+               return -EINVAL;
 
-       return 0;
+       return _clkdm_clk_hwmod_disable(clkdm);
 }